Make sure function that checks content-type header value accepts nil content-type header value#3234
Merged
Merged
Conversation
github-actions
Bot
added
appsec
cbeauchesne
reviewed
Oct 30, 2023
cbeauchesne
left a comment
cbeauchesne
left a comment
Contributor
There was a problem hiding this comment.
What about adding rack/APPSEC_API_SECURITY in your CI ?
added 2 commits
October 31, 2023 10:27
is valid for parsing the response body and supports when there are no content-type header information.
GustavoCaso
force-pushed
the
asm-fix-response-body-parse-logic
branch
from
October 31, 2023 09:28
89cc892 to
79961b8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3234 +/- ##
==========================================
- Coverage 98.22% 98.21% -0.01%
==========================================
Files 1252 1252
Lines 72201 72206 +5
Branches 3353 3353
==========================================
+ Hits 70917 70919 +2
- Misses 1284 1287 +3
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cbeauchesne
approved these changes
Oct 31, 2023
lloeki
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix regression introduce in b195274
Make sure that the function that checks if the content-type header
is valid for parsing the response body
and supports when there is no content-type header information.
Motivation:
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!