Name Datadog::Core::Remote::Worker thread#3207
Merged
Merged
Conversation
ivoanjo
changed the title
Datadog::Core::Remote::Worker thread
ekump
approved these changes
Oct 18, 2023
**What does this PR do?** This PR sets the name of the thread started by the `Datadog::Core::Remote::Worker` class (to be the name of the class). This follows the same pattern we use for other dd-trace-rb internal threads. **Motivation:** The profiler shows thread names in multiple places, and nameless threads make it harder to see the data in several cases, so as much as possible we want to avoid them. One particular case is that for the timeline feature, we collapse all dd-trace-rb threads by default, but that collapsing feature relies on thread names, and so the remote worker thread was not being properly collapsed (which is how I spotted it). **Additional Notes:** I've chosen to still include the Ruby 2.2/2.1 support because I plan to backport this to the 1.x branch. **How to test the change?** This change includes test coverage. You can also enable the profiler and check that when looking at thread names (right sidebar in single and aggregated profiles; left side for timeline) you will see the thread for this class properly named.
ivoanjo
force-pushed
the
ivoanjo/name-core-remote-worker-thread
branch
from
October 24, 2023 13:12
81d6996 to
64b1769
Compare
Member
Author
|
Update: I had tried to merge master into this branch but that triggered a bunch of gemfile updates that were missing. Instead, I pulled the gemfile updates into a separate PR (#3213) and rebased this branch on top of master once that other PR got merged. |
ivoanjo
added a commit
that referenced
this pull request
Oct 25, 2023
…te-worker-thread Backport #3207 to 1.x-stable: Name `Datadog::Core::Remote::Worker` thread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets the name of the thread started by the
Datadog::Core::Remote::Workerclass (to be the name of the class).This follows the same pattern we use for other dd-trace-rb internal threads.
Motivation:
The profiler shows thread names in multiple places, and nameless threads make it harder to see the data in several cases, so as much as possible we want to avoid them.
One particular case is that for the timeline feature, we collapse all dd-trace-rb threads by default, but that collapsing feature relies on thread names, and so the remote worker thread was not being properly collapsed (which is how I spotted it).
Additional Notes:
I've chosen to still include the Ruby 2.2/2.1 support because I plan to backport this to the 1.x branch.
How to test the change?
This change includes test coverage. You can also enable the profiler and check that when looking at thread names (right sidebar in single and aggregated profiles; left side for timeline) you will see the thread for this class properly named.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.