skip passing waf addresses when the value is empty#3188
Merged
Conversation
github-actions
Bot
added
appsec
GustavoCaso
force-pushed
the
asm-skip-empty-waf-addresses
branch
2 times, most recently
from
October 6, 2023 09:00
75c44b0 to
8bcc903
Compare
GustavoCaso
marked this pull request as ready for review
October 6, 2023 09:01
GustavoCaso
force-pushed
the
asm-skip-empty-waf-addresses
branch
from
October 6, 2023 09:05
8bcc903 to
b76da9f
Compare
lloeki
approved these changes
Oct 6, 2023
lloeki
left a comment
lloeki
left a comment
Member
There was a problem hiding this comment.
LGTM as a solution, although as is the code seems to have some holes.
GustavoCaso
force-pushed
the
asm-skip-empty-waf-addresses
branch
from
October 6, 2023 14:18
6a85420 to
fcca011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We remove empty and nil WAF Addresses before sending it to the WAF to be processed.
Motivation:
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!