remove CI module and add a dependency on datadog-ci gem#3128
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3128 +/- ##
==========================================
- Coverage 98.17% 98.14% -0.03%
==========================================
Files 1326 1281 -45
Lines 75575 73715 -1860
Branches 3506 3423 -83
==========================================
- Hits 74192 72347 -1845
+ Misses 1383 1368 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Looking good! 👍 |
Collaborator
|
Perhaps we should change gemspec to add runtime dependency for ci ? |
Member
Author
|
@TonyCTHsu didn't I add it to gemspec? I think it is here https://github.com/DataDog/dd-trace-rb/pull/3128/files#diff-8b1801e03e9a166eea28410efc558b347e0b4a3bc03ab6c7283afa4479e88756R72 and all the regenerated gemfiles for appraisals now show datadog-ci (0.1.0) |
anmarchenko
force-pushed
the
anmarchenko/migrate_ci_phase_1
branch
from
September 14, 2023 10:20
babac4a to
6dd44c6
Compare
anmarchenko
marked this pull request as ready for review
September 14, 2023 11:22
anmarchenko
force-pushed
the
anmarchenko/migrate_ci_phase_1
branch
from
September 14, 2023 11:35
cf14e72 to
ec58040
Compare
Collaborator
|
🕶️ I was blind |
TonyCTHsu
approved these changes
Sep 14, 2023
add datadog-ci to the host_inject script
anmarchenko
force-pushed
the
anmarchenko/migrate_ci_phase_1
branch
from
September 15, 2023 07:27
bb4970a to
430aa03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Phase 1 of the CI migration:
Motivation:
Remove code duplication between gems
Additional Notes:
Not that it is a new runtime dependency I changed
host_inject.rbscript to installdatadog-cihere:https://github.com/DataDog/dd-trace-rb/pull/3128/files#diff-112f50906c11b7190b1561f372bd7298abe32cda4be0054ced470a584cffb7d3R66
Is there a way to test this? cc @TonyCTHsu
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!