Fix tagging with empty data#3102
Merged
Merged
Conversation
anmarchenko
approved these changes
Sep 1, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3102 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 1323 1323
Lines 75085 75094 +9
Branches 3421 3421
=======================================
+ Hits 73702 73711 +9
Misses 1383 1383 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcotc
approved these changes
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3088
What does this PR do?
An object includes Tagging module, but
#tagsmethod raiseNoMethodError: undefined method 'merge' for nil:NilClassorTypeError: no implicit conversion of nil into HashBecause the instance variables are
nil.The fix is to replace instance variable with protected attribute reader.