Remove depends_on from Core Configuration option#3085
Merged
Conversation
github-actions
Bot
added
core
GustavoCaso
changed the title
depends_on from Core Configuration option
GustavoCaso
force-pushed
the
core-configuration-remove-depends-on-option
branch
2 times, most recently
from
August 28, 2023 16:07
7b4c1b8 to
af9ee8b
Compare
GustavoCaso
force-pushed
the
core-configuration-remove-depends-on-option
branch
from
August 28, 2023 16:18
af9ee8b to
5f0804e
Compare
GustavoCaso
marked this pull request as ready for review
August 28, 2023 16:29
marcotc
approved these changes
Aug 28, 2023
marcotc
left a comment
marcotc
left a comment
Member
There was a problem hiding this comment.
Let's make sure to include in this in our changelog.
Because this feature hasn't been functional to its advertised intent for quite some time, I'm 👍 to remove it in its current form.
Member
|
Nice, hooray for less complexity! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Based on internal conversations, we agreed that
depends_onis a feature from the past and that is no longer used. It has been replaced with the different components. Because of that we agreed that it was good to remove it 🔥Motivation:
We are cleaning up the codebase from options we no longer use.
I was able to remove the following:
depends_onoption from the configuration DSLConfiguration::DependencyResolver.Configuration::OptionDefinitionSet. It was inherited from Hash, and the only functionality added was to organize the options in order using thedepends_onattribute. I replaced it with a normal Hash.Configuration::OptionSet. It was inherited from Hash, but we were not extending the class with any particular functionality. I replaced it with a normal Hash.Additional Notes:
How to test the change?
CI must be 🟢
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!