Implements _dd.base_service tag#3018
Merged
Merged
Conversation
delner
suggested changes
Aug 2, 2023
delner
left a comment
delner
left a comment
Contributor
There was a problem hiding this comment.
Please wait until I have a chance to review. Thanks!
Contributor
Author
|
System tests were changed a bit during development so after consulting @wconti27, I applied the fix for that in this PR as well. No impact should be made to functionality |
zarirhamza
force-pushed
the
zarir/base_service
branch
2 times, most recently
from
August 22, 2023 16:29
1b48d32 to
a1c5496
Compare
Codecov Report
@@ Coverage Diff @@
## master #3018 +/- ##
==========================================
- Coverage 98.15% 98.15% -0.01%
==========================================
Files 1323 1323
Lines 75075 75130 +55
Branches 3425 3471 +46
==========================================
+ Hits 73691 73744 +53
- Misses 1384 1386 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zarirhamza
force-pushed
the
zarir/base_service
branch
from
August 23, 2023 18:46
a1c5496 to
6028788
Compare
delner
approved these changes
Sep 6, 2023
delner
left a comment
delner
left a comment
Contributor
There was a problem hiding this comment.
@zarirhamza and I reviewed this together. May need a refactor later to reduce repetition, create consistency, but approach seems "OK" for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
_dd.base_servicetag which captures the global service name IFF the span.service is not equivalent to the global service name, implying it was overridden and a fake service was implemented.