Tell agent to trust tracer top-level span tagging#2138
Merged
Conversation
marcotc
force-pushed
the
computed-top-level-header
branch
from
July 8, 2022 01:22
bce4eb9 to
d5c9a44
Compare
TonyCTHsu
approved these changes
Jul 8, 2022
marcotc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #2137.
This PR lets the Agent know that the tracer has calculated top-level spans and tagged them appropriately.
This prevents partially flushed trace segments from being considered top-level, which used to create incorrect metrics and increase the resource name cardinality for the affected service name.
Any value can be set in the HTTP header. The agent simply checks if it's not empty.
(If you are still confused, the description of #2137 has all the information regarding this and the previous PR)