Add Utility to Collect Platform Information#2097
Merged
Merged
Conversation
marcotc
reviewed
Jun 20, 2022
marcotc
requested changes
Jun 20, 2022
marcotc
left a comment
marcotc
left a comment
Member
There was a problem hiding this comment.
Let's make sure these methods only return not-nil when we are confident of the values.
For example, for JRuby, we should only return values if they reflect uname -foo.
marcotc
reviewed
Jun 20, 2022
jennchenn
added a commit
that referenced
this pull request
Jun 23, 2022
* Add host information utility * fixup! Add host information utility * Rename file to platform * fixup! Rename file to platform * Require etc in file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added module to collect information on the platform that dd-trace is running on. This information will be used in telemetry API requests (payload spec can be found here).
Open Questions
osandos_version--theenvironment_logger.rbfile usesRbConfigto get the os name (here). This doesn't match the value fromuname -oexactly as it also includes architecture information (GNU/Linuxvs.aarch64-unknown-linux-gnu); however, would it be better to send that value anyway rather than sending nothing?