Skip to content

Net::HTTP moved to its own gem since Ruby 3.0 #2184

New issue
New issue
Closed
#5317
Closed
Net::HTTP moved to its own gem since Ruby 3.0#2184
#5317
Labels
feature-requestA request for a new feature or change to an existing oneintegrationsInvolves tracing integrations
@marcotc

Description

@marcotc
marcotc
opened on Jul 26, 2022

The Net::HTTP Ruby library can be installed and upgraded separately from the Ruby standard library since Ruby 3.0.0.

This means that the http integration's minimum supported version is now misleading:

dd-trace-rb/lib/datadog/tracing/contrib/http/integration.rb

Lines 21 to 27 in df224ac

MINIMUM_VERSION = DDTrace::VERSION::MINIMUM_RUBY_VERSION
# @public_api Changing the integration name or integration options can cause breaking changes
register_as :http, auto_patch: true
def self.version
Gem::Version.new(RUBY_VERSION)

I has currently has its minimum version set to the current Ruby version.

We should correctly mark which version of the net-http gem we support: rubygems.org/gems/net-http.

Also, if possible, we should rename the integration to net-http. This can cause breaking configuration changes when implemented (e.g. c.tracing.instrument :http will likely be changed).

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature-requestA request for a new feature or change to an existing oneintegrationsInvolves tracing integrations

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions