SymDB: skip subclass+autoload test on Ruby < 2.7

p-ddsign · claude · p-ddsign · commit fe6b07dbf641 · 2026-06-09T14:29:16.000-04:00
The "subclass with constant of same name as ancestor pending autoload"
test verifies that resolves_to_same_module? distinguishes a real
subclass binding from an ancestor's pending autoload. That distinction
requires Module#autoload?(name, false) to query autoloads registered
directly on a namespace without checking ancestors. The `inherit`
parameter was added in Ruby 2.7 (Ruby 2.7.0 NEWS).

On Ruby 2.5/2.6 the implementation falls back to Module#autoload?(name)
which checks ancestors — so a subclass binding that collides with an
ancestor's pending autoload is conservatively treated as stale and
dropped. That fallback is documented in resolves_to_same_module?'s YARD
comment and is unavoidable without the 2.7+ API.

Skip the test on Ruby &lt; 2.7 to align verification with the platform
that supports the asserted behavior. The conservative-fallback behavior
on 2.5/2.6 is already exercised by every leaked-class case in
collect_extractable_modules.

Co-Authored-By: Claude &lt;noreply@anthropic.com&gt;
diff --git a/spec/datadog/symbol_database/extractor_spec.rb b/spec/datadog/symbol_database/extractor_spec.rb
@@ -2337,6 +2337,17 @@ def host_method; end
       # The fix relies on the order of operations: const_defined?(sym, false)
       # detects the direct subclass binding first, and const_get(sym, false)
       # returns it without triggering the ancestor's autoload.
+      #
+      # Requires Module#autoload?(name, inherit) — the `inherit` parameter was
+      # added in Ruby 2.7 (Ruby 2.7.0 NEWS). On Ruby 2.5/2.6 the fallback in
+      # resolves_to_same_module? uses autoload?(name) which checks ancestors,
+      # so a subclass binding that collides with an ancestor's pending
+      # autoload is conservatively treated as stale and dropped. That is the
+      # documented fallback behavior and is unavoidable without the 2.7+ API.
+      before(:all) do
+        skip 'requires Module#autoload?(name, inherit) — Ruby 2.7+' if RUBY_VERSION < '2.7'
+      end
+
       before do
         @parent_file = create_test_file('autoload_parent.rb', <<~RUBY)
           class ExtractAllAutoloadParent
