SymDB extractor spec: restore top-level rescue test

p-ddsign · p-ddsign · commit 78301e1efff0 · 2026-05-18T12:15:25.000-04:00
#5717 deleted the spec at extractor_spec.rb that exercised the top-level rescue in Extractor#extract_all. The production rescue is still in place at extractor.rb:149-151 — the deletion was an unintentional artifact of the squash rebase and left the rescue path uncovered. Restore the original test so the rescue is exercised again.
diff --git a/spec/datadog/symbol_database/extractor_spec.rb b/spec/datadog/symbol_database/extractor_spec.rb
@@ -1667,6 +1667,17 @@ def extract_all_clean
       extractor.extract_all
     end
 
+    context 'top-level rescue' do
+      it 'returns [] and logs when collection raises' do
+        allow(extractor).to receive(:collect_extractable_modules).and_raise(StandardError, 'boom')
+        expect(logger).to receive(:debug) { |&block| expect(block.call).to match(/extract_all.*StandardError.*boom/i) }
+
+        result = extractor.extract_all
+
+        expect(result).to eq([])
+      end
+    end
+
     context 'simple class in one file' do
       before do
         @file = create_test_file('user.rb', <<~RUBY)
