SymDB scope: restore wire-format-vs-Ruby-identifier comment

p-ddsign · p-ddsign · commit 0da6cc281a6b · 2026-05-18T12:15:19.000-04:00
The Scope :targetable_lines comment at scope.rb:25 was rewritten in #5717 in a way that lost the distinction between the Ruby identifier (targetable_lines) and the wire-format key (has_injectible_lines). The same file at lines 83-88 still serializes with the historical +injectible+ spelling for backend compatibility, so the line-25 comment contradicted the actual implementation in the same file. Restore the original comment so the wire-format key name is documented next to the Struct member it describes. Also rename the scope_spec.rb test description that propagated the same wrong wording ("includes targetable_lines?: false") to match what the test body actually asserts ("emits has_injectible_lines: false").
diff --git a/lib/datadog/symbol_database/scope.rb b/lib/datadog/symbol_database/scope.rb
@@ -22,8 +22,10 @@ class Scope
         # - nil: not computed (source unreadable, native/C-extension method)
         # - []: computed but no executable lines found (comments/whitespace only)
         # - non-empty: computed, contains executable line ranges
-        # nil and [] both serialize as targetable_lines?: false on METHOD
-        # scopes. Key is absent on non-METHOD scopes.
+        # nil and [] both serialize as has_injectible_lines: false on METHOD
+        # scopes. Key is absent on non-METHOD scopes. The wire format key
+        # name keeps the historical spelling +injectible+ for backend
+        # compatibility; the Ruby identifier is +targetable_lines+.
         :targetable_lines,
         :language_specifics, :symbols, :scopes
 
diff --git a/spec/datadog/symbol_database/scope_spec.rb b/spec/datadog/symbol_database/scope_spec.rb
@@ -260,7 +260,7 @@
       expect(hash[:injectible_lines]).to eq([{start: 10, end: 12}, {start: 15, end: 15}])
     end
 
-    it 'includes targetable_lines?: false on METHOD scope without ranges' do
+    it 'emits has_injectible_lines: false on METHOD scope without ranges' do
       scope = described_class.new(
         scope_type: 'METHOD',
         name: 'native_method',
