feat(dbm): add peer entity dbm comment attributes#8286
Merged
Conversation
rarguelloF
force-pushed
the
rarguelloF/AIT-9563/dbm-peer-entity-tags
branch
from
February 5, 2024 11:10
62f8dd2 to
f21d056
Compare
tabgok
reviewed
Feb 5, 2024
BenchmarksBenchmark execution time: 2024-02-26 13:17:11 Comparing candidate commit e9e86ec in PR branch Found 3 performance improvements and 3 performance regressions! Performance is the same for 197 metrics, 9 unstable metrics. scenario:flasksimple-appsec-get
scenario:flasksimple-appsec-telemetry
scenario:otelspan-start
scenario:samplingrules-average_match
scenario:samplingrules-high_match
scenario:span-add-metrics
|
tabgok
reviewed
Feb 6, 2024
Datadog ReportBranch report: ✅ 0 Failed, 27323 Passed, 33044 Skipped, 6h 48m 31.45s Total duration (1h 56m 42.81s time saved) |
emmettbutler
approved these changes
Feb 15, 2024
tabgok
approved these changes
Feb 16, 2024
joelmarcotte
approved these changes
Feb 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following 2 new attributes to the DBM injected query comments:
ddh: represents the peer hostname of the request.dddb: represents the db instance.These tags are necessary so the APM<->DBM connection still works when using the
peer.servicepowered features.Integrations affected:
psycopgpsycopg2The following integrations support DBM comment injection but do not set tags with information about the db name or peer hostname, so the comment attributes won't be added:
dbapidbapi_asyncChecklist
changelog/no-changelogis set@DataDog/apm-tees.@DataDog/security-design-and-guidance.Reviewer Checklist