[celery] Don't mark expected failures as errors#820
Merged
brettlangdon merged 4 commits intoFeb 22, 2019
Conversation
sciyoshi
force-pushed
the
celery-expected-failures
branch
from
February 11, 2019 21:46
50555b4 to
cdbe2c6
Compare
Kyle-Verhoog
approved these changes
Feb 15, 2019
Kyle-Verhoog
left a comment
Kyle-Verhoog
left a comment
Member
There was a problem hiding this comment.
lgtm, thanks for the contribution (and tests!!) @sciyoshi 😄
| ok_('Traceback (most recent call last)' in span.get_tag('error.stack')) | ||
| ok_('Task class is failing' in span.get_tag('error.stack')) | ||
|
|
||
| def test_class_task_exception_expected(self): |
| ok_('Traceback (most recent call last)' in span.get_tag('error.stack')) | ||
| ok_('Task class is failing' in span.get_tag('error.stack')) | ||
|
|
||
| def test_fn_exception_expected(self): |
brettlangdon
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Celery supports a Task.throws option for expected task failures. This PR adds a check to skip reporting error tags if a task throws one of those exceptions. @Kyle-Verhoog