[core] add six and replace custom compat functions#751
Merged
Conversation
Member
Author
|
#755 is proving to be a bit more difficult, and it is exposing some potential issues with this vendoring approach. We should consider both PRs in tandem on whether/if/how we should be doing vendoring. |
brettlangdon
changed the title
Kyle-Verhoog
approved these changes
Dec 7, 2018
Kyle-Verhoog
left a comment
Kyle-Verhoog
left a comment
Member
There was a problem hiding this comment.
The changes are good 👍. I'm not convinced that our compat functions are 100% equivalent to the six alternatives. While our tests pass, I wonder whether we should do some more thorough testing since these are pretty substantial changes.
Member
Author
|
From what I can tell, a few of them looked like copy/pasta. I agree, but I am also willing to bet that |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
sixas a dependency and aliases ourddtrace.compatproperties to the appropriatesixonescompat_async.pyintocompat.py