chore(profiler): remove resolved known issue for profiler on Python 3.11#5153
Merged
Conversation
Yun-Kim
added
the
changelog/no-changelog
ZStriker19
approved these changes
Feb 17, 2023
Yun-Kim
requested review from
brettlangdon
and removed request for
christophe-papazian and
juanjux
February 17, 2023 20:09
brettlangdon
left a comment
brettlangdon
left a comment
Member
There was a problem hiding this comment.
do we want to delete this or just omit it from our read the docs generation for 1.8 ?
brettlangdon
approved these changes
Feb 17, 2023
Codecov Report
@@ Coverage Diff @@
## 1.x #5153 +/- ##
=======================================
Coverage 74.64% 74.64%
=======================================
Files 860 860
Lines 65921 65921
=======================================
Hits 49208 49208
Misses 16713 16713 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ZStriker19
pushed a commit
that referenced
this pull request
Feb 17, 2023
….11 (#5153) This PR removes the known issue release note for the profiler on Python 3.11 relating to `PyFrameObjects`, which was mitigated by #5019. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) are followed. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Author is aware of the performance implications of this PR as reported in the benchmarks PR comment. ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer is aware of, and discussed the performance implications of this PR as reported in the benchmarks PR comment. (cherry picked from commit 066688c)
15 tasks
brettlangdon
pushed a commit
that referenced
this pull request
Feb 17, 2023
….11 [backport #5153 to 1.8] (#5154) Backport of #5153 to 1.8 This PR removes the known issue release note for the profiler on Python 3.11 relating to `PyFrameObjects`, which was mitigated by #5019. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) are followed. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Author is aware of the performance implications of this PR as reported in the benchmarks PR comment. ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer is aware of, and discussed the performance implications of this PR as reported in the benchmarks PR comment. Co-authored-by: Yun Kim <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the known issue release note for the profiler on Python 3.11 relating to
PyFrameObjects, which was mitigated by #5019.Checklist
Reviewer Checklist