fix(profiler): handle non-frame objects while stack-unwinding [backport 1.8]#5091
Merged
Conversation
brettlangdon
previously approved these changes
Feb 9, 2023
P403n1x87
previously approved these changes
Feb 9, 2023
majorgreys
enabled auto-merge (squash)
February 9, 2023 16:42
Codecov Report
@@ Coverage Diff @@
## 1.8 #5091 +/- ##
==========================================
- Coverage 74.89% 74.88% -0.01%
==========================================
Files 816 816
Lines 63501 63501
==========================================
- Hits 47557 47554 -3
- Misses 15944 15947 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Following reports of Python 3.11 returning non-frame objects while unwinding the stack of a running thread, this change adds handling code that prevents exceptions from being raised. (cherry picked from commit ea7c9c6)
brettlangdon
dismissed stale reviews from P403n1x87 and themself
via
February 10, 2023 12:54
c6b59c6
brettlangdon
force-pushed
the
backport-5019-to-1.8
branch
from
February 10, 2023 12:54
65e25b7 to
c6b59c6
Compare
brettlangdon
approved these changes
Feb 10, 2023
P403n1x87
approved these changes
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport ea7c9c6 from #5019 to 1.8.
Following reports of Python 3.11 returning non-frame objects while unwinding the stack of a running thread, this change adds handling code that prevents exceptions from being raised.
Checklist
Reviewer Checklist