Skip to content

fix(profiler): handle non-frame objects while stack-unwinding [backport 1.8]#5091

Merged
majorgreys merged 1 commit into
1.8from
backport-5019-to-1.8
Feb 10, 2023
Merged

fix(profiler): handle non-frame objects while stack-unwinding [backport 1.8]#5091
majorgreys merged 1 commit into
1.8from
backport-5019-to-1.8

Conversation

@github-actions

@github-actions github-actions Bot commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

Backport ea7c9c6 from #5019 to 1.8.

Following reports of Python 3.11 returning non-frame objects while unwinding the stack of a running thread, this change adds handling code that prevents exceptions from being raised.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.

@github-actions
github-actions Bot requested a review from a team as a code owner February 9, 2023 16:29
@github-actions github-actions Bot added the Profiling Continous Profling label Feb 9, 2023
brettlangdon
brettlangdon previously approved these changes Feb 9, 2023
P403n1x87
P403n1x87 previously approved these changes Feb 9, 2023
@majorgreys
majorgreys enabled auto-merge (squash) February 9, 2023 16:42
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #5091 (65e25b7) into 1.8 (fd6de8d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              1.8    #5091      +/-   ##
==========================================
- Coverage   74.89%   74.88%   -0.01%     
==========================================
  Files         816      816              
  Lines       63501    63501              
==========================================
- Hits        47557    47554       -3     
- Misses      15944    15947       +3     
Impacted Files Coverage Δ
ddtrace/internal/remoteconfig/worker.py 42.30% <0.00%> (-3.85%) ⬇️
ddtrace/internal/telemetry/writer.py 34.48% <0.00%> (-2.07%) ⬇️
tests/utils.py 90.42% <0.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Following reports of Python 3.11 returning non-frame objects while
unwinding the stack of a running thread, this change adds handling code
that prevents exceptions from being raised.

(cherry picked from commit ea7c9c6)
@brettlangdon
brettlangdon dismissed stale reviews from P403n1x87 and themself via c6b59c6 February 10, 2023 12:54
@majorgreys
majorgreys merged commit 4950e58 into 1.8 Feb 10, 2023
@majorgreys
majorgreys deleted the backport-5019-to-1.8 branch February 10, 2023 13:13
@github-actions github-actions Bot added this to the v1.8.0 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Profiling Continous Profling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants