Skip to content

feat(graphql,graphene): add support for Python 3.11#5037

Merged
emmettbutler merged 6 commits into
DataDog:1.xfrom
Yun-Kim:yunkim/graphene-graphql-3-11
Feb 6, 2023
Merged

feat(graphql,graphene): add support for Python 3.11#5037
emmettbutler merged 6 commits into
DataDog:1.xfrom
Yun-Kim:yunkim/graphene-graphql-3-11

Conversation

@Yun-Kim

@Yun-Kim Yun-Kim commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

Checklist

Blocked by #4854.

This change adds Python 3.11 testing to our graphql and graphene test suites.

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.

@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 3, 2023
@Yun-Kim
Yun-Kim requested a review from a team as a code owner February 3, 2023 15:50
Comment thread riotfile.py Outdated
Comment thread riotfile.py Outdated
@emmettbutler
emmettbutler self-requested a review February 6, 2023 15:53
emmettbutler
emmettbutler previously approved these changes Feb 6, 2023
@emmettbutler
emmettbutler enabled auto-merge (squash) February 6, 2023 15:53

@mabdinur mabdinur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a release note?

@mabdinur mabdinur changed the title chore(graphene,graphql): add Python 3.11 testing for graphene/graphql tests feat(graphql): add support for Python 3.11 Feb 6, 2023
@Yun-Kim Yun-Kim changed the title feat(graphql): add support for Python 3.11 feat(graphql,graphene): add support for Python 3.11 Feb 6, 2023
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #5037 (f1cdaa1) into 1.x (8ece878) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              1.x    #5037   +/-   ##
=======================================
  Coverage   74.90%   74.90%           
=======================================
  Files         827      827           
  Lines       64199    64199           
=======================================
+ Hits        48087    48088    +1     
+ Misses      16112    16111    -1     
Impacted Files Coverage Δ
ddtrace/internal/telemetry/writer.py 34.01% <0.00%> (+0.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Yun-Kim
Yun-Kim force-pushed the yunkim/graphene-graphql-3-11 branch from f1cdaa1 to 9818b28 Compare February 6, 2023 19:49
brettlangdon
brettlangdon previously approved these changes Feb 6, 2023

@brettlangdon brettlangdon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could have included both notes in one release note file.

Comment thread releasenotes/notes/feat-graphql-py-3-11-5431bd3eedb38c50.yaml Outdated
@emmettbutler
emmettbutler merged commit 8c1d99a into DataDog:1.x Feb 6, 2023
@Yun-Kim
Yun-Kim deleted the yunkim/graphene-graphql-3-11 branch February 6, 2023 20:20
@Yun-Kim Yun-Kim mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants