Skip to content

chore(profiler): add known issue changelog for Python 3.11 PyFrameObject#4952

Merged
Yun-Kim merged 3 commits into
DataDog:1.xfrom
Yun-Kim:yunkim/known-prof-3-11-issue
Jan 24, 2023
Merged

chore(profiler): add known issue changelog for Python 3.11 PyFrameObject#4952
Yun-Kim merged 3 commits into
DataDog:1.xfrom
Yun-Kim:yunkim/known-prof-3-11-issue

Conversation

@Yun-Kim

@Yun-Kim Yun-Kim commented Jan 23, 2023

Copy link
Copy Markdown
Contributor

Description

As #4895 has not been merged yet and we don't want to block the 1.8 release any longer, this PR adds a release note entry publishing the known issue of the profiler running in Python 3.11 with the new PyFrameObject opaque struct changes.

Checklist

Motivation

Design

Testing strategy

Relevant issue(s)

Testing strategy

Reviewer Checklist

  • Title is accurate.
  • Description motivates each change.
  • No unnecessary changes were introduced in this PR.
  • Avoid breaking API changes unless absolutely necessary.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Release note has been added and follows the library release note guidelines, or else changelog/no-changelog label added.
  • All relevant GitHub issues are correctly linked.
  • Change contains telemetry where appropriate (logs, metrics, etc.).
  • Telemetry is meaningful, actionable and does not have the potential to leak sensitive data.

@Yun-Kim
Yun-Kim requested a review from a team as a code owner January 23, 2023 22:19
@codecov-commenter

codecov-commenter commented Jan 23, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.71%. Comparing base (5593911) to head (25a0154).
⚠️ Report is 1106 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #4952      +/-   ##
==========================================
- Coverage   74.71%   74.71%   -0.01%     
==========================================
  Files         817      817              
  Lines       63485    63485              
==========================================
- Hits        47435    47434       -1     
- Misses      16050    16051       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread releasenotes/notes/prof-3-11-traceback-issue-20e06214d4a3879b.yaml
Comment thread releasenotes/notes/prof-3-11-traceback-issue-20e06214d4a3879b.yaml
@Yun-Kim
Yun-Kim merged commit ac04ab6 into DataDog:1.x Jan 24, 2023
@Yun-Kim
Yun-Kim deleted the yunkim/known-prof-3-11-issue branch January 24, 2023 19:15
emmettbutler pushed a commit that referenced this pull request Jan 30, 2023
…ect (#4952)

## Description
As #4895 has not been merged yet and we don't want to block the 1.8
release any longer, this PR adds a release note entry publishing the
known issue of the profiler running in Python 3.11 with the new
`PyFrameObject` opaque struct changes.

<!-- If this is a breaking change, explain why it is necessary. Breaking
changes must append `!` after the type/scope. See
https://ddtrace.readthedocs.io/en/stable/contributing.html for more
details. -->

## Checklist
- [ ] Followed the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines)
when writing a release note.
- [ ] Add additional sections for `feat` and `fix` pull requests.
- [ ] [Library
documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs)
and/or [Datadog's documentation
site](https://github.com/DataDog/documentation/) is updated. Link to doc
PR in description.

<!-- Copy and paste the relevant snippet based on the type of pull
request -->

<!-- START feat -->

## Motivation
<!-- Expand on why the change is required, include relevant context for
reviewers -->

## Design 
<!-- Include benefits from the change as well as possible drawbacks and
trade-offs -->

## Testing strategy
<!-- Describe the automated tests and/or the steps for manual testing.

<!-- END feat -->

<!-- START fix -->

## Relevant issue(s)
<!-- Link the pull request to any issues related to the fix. Use
keywords for links to automate closing the issues once the pull request
is merged. -->

## Testing strategy
<!-- Describe any added regression tests and/or the manual testing
performed. -->

<!-- END fix -->

## Reviewer Checklist
- [ ] Title is accurate.
- [ ] Description motivates each change.
- [ ] No unnecessary changes were introduced in this PR.
- [ ] Avoid breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [ ] Tests provided or description of manual testing performed is
included in the code or PR.
- [ ] Release note has been added and follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines),
or else `changelog/no-changelog` label added.
- [ ] All relevant GitHub issues are correctly linked.
- [ ] Change contains telemetry where appropriate (logs, metrics, etc.).
- [ ] Telemetry is meaningful, actionable and does not have the
potential to leak sensitive data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants