Skip to content

Comments

ci(httpx): pin tested version to v0.22.0 [0.61 branch]#4769

Merged
brettlangdon merged 2 commits into0.61from
backport-4595-0-61
Dec 22, 2022
Merged

ci(httpx): pin tested version to v0.22.0 [0.61 branch]#4769
brettlangdon merged 2 commits into0.61from
backport-4595-0-61

Conversation

@mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Dec 9, 2022

Description

CI mitigation for issue addressed in this PR #4595

Reviewer Checklist

  • Title is accurate.
  • Description motivates each change.
  • No unnecessary changes were introduced in this PR.
  • Avoid breaking API changes unless absolutely necessary.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Release note has been added and follows the library release note guidelines, or else changelog/no-changelog label added.
  • All relevant GitHub issues are correctly linked.
  • Backports are identified and tagged with Mergifyio.

## Description
[As of `httpx==0.23.1`](encode/httpx#2241), the `URL.raw` property was removed, which broke our `_url_to_str()` helper that uses that property to construct the raw URL.

However, the removed property was simply a combination of already existing (and still existing) properties in the `URL` object, which we can use to manually consturct the raw URL. I've version gated it such that nothing's changed for previous versions of `httpx`, but moving forward we'll manually construct the raw URL.



## Checklist
- [x] Add additional sections for `feat` and `fix` pull requests.
- [x] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description.





## Motivation


## Design 


## Testing strategy




## Relevant issue(s)


## Testing strategy




## Reviewer Checklist
- [ ] Title is accurate.
- [ ] Description motivates each change.
- [ ] No unnecessary changes were introduced in this PR.
- [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary.
- [ ] Tests provided or description of manual testing performed is included in the code or PR.
- [ ] Release note has been added for fixes and features, or else `changelog/no-changelog` label added.
- [ ] All relevant GitHub issues are correctly linked.
- [ ] Backports are identified and tagged with Mergifyio.
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 9, 2022
@mabdinur mabdinur changed the base branch from 1.x to 0.61 December 9, 2022 20:49
@mabdinur mabdinur marked this pull request as ready for review December 9, 2022 20:49
@mabdinur mabdinur requested a review from a team as a code owner December 9, 2022 20:49
@mabdinur
Copy link
Contributor Author

Instead of backport the fix we can pin httpx to ==0.22.0 to unblock ci. Fixing the underlying issue seems simple enough so I prefer this approach.

@mabdinur mabdinur changed the title fix(httpx): manually construct removed URL.raw property [backport #4595 to 0.61] ci(httpx): pin tested version to v0.22.0 Dec 12, 2022
@mabdinur mabdinur changed the title ci(httpx): pin tested version to v0.22.0 ci(httpx): pin tested version to v0.22.0 [0.61 branch] Dec 13, 2022
@brettlangdon brettlangdon merged commit 4309faa into 0.61 Dec 22, 2022
@brettlangdon brettlangdon deleted the backport-4595-0-61 branch December 22, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants