Skip to content

Comments

fix(httpx): manually construct removed URL.raw property (backport #4595)#4596

Merged
brettlangdon merged 1 commit into1.6from
mergify/bp/1.6/pr-4595
Nov 21, 2022
Merged

fix(httpx): manually construct removed URL.raw property (backport #4595)#4596
brettlangdon merged 1 commit into1.6from
mergify/bp/1.6/pr-4595

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 21, 2022

This is an automatic backport of pull request #4595 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

## Description
[As of `httpx==0.23.1`](encode/httpx#2241), the `URL.raw` property was removed, which broke our `_url_to_str()` helper that uses that property to construct the raw URL.

However, the removed property was simply a combination of already existing (and still existing) properties in the `URL` object, which we can use to manually consturct the raw URL. I've version gated it such that nothing's changed for previous versions of `httpx`, but moving forward we'll manually construct the raw URL.

## Checklist
- [x] Add additional sections for `feat` and `fix` pull requests.
- [x] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description.

## Motivation

## Design

## Testing strategy

## Relevant issue(s)

## Testing strategy

## Reviewer Checklist
- [ ] Title is accurate.
- [ ] Description motivates each change.
- [ ] No unnecessary changes were introduced in this PR.
- [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary.
- [ ] Tests provided or description of manual testing performed is included in the code or PR.
- [ ] Release note has been added for fixes and features, or else `changelog/no-changelog` label added.
- [ ] All relevant GitHub issues are correctly linked.
- [ ] Backports are identified and tagged with Mergifyio.

(cherry picked from commit 6a1948d)
@mergify mergify bot requested a review from a team as a code owner November 21, 2022 13:24
@brettlangdon
Copy link
Member

This depends on adding the release note #4597

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 21, 2022
@brettlangdon brettlangdon merged commit 0b01239 into 1.6 Nov 21, 2022
@brettlangdon brettlangdon deleted the mergify/bp/1.6/pr-4595 branch November 21, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants