feat(profiling): add support for Python 3.11#4511
Merged
Merged
Conversation
14 tasks
jd
force-pushed
the
profiling/py311
branch
5 times, most recently
from
November 9, 2022 17:35
7826625 to
2f8f38e
Compare
Yun-Kim
reviewed
Nov 9, 2022
Yun-Kim
left a comment
Yun-Kim
left a comment
Contributor
There was a problem hiding this comment.
Lines 147/148 in tox.ini missing Python 3.11 specification.
Kyle-Verhoog
left a comment
Kyle-Verhoog
left a comment
Member
There was a problem hiding this comment.
Looks good, just a question about the tenacity change
Kyle-Verhoog
previously approved these changes
Nov 14, 2022
Contributor
|
@jd this pull request is now in conflict 😩 |
mabdinur
reviewed
Nov 17, 2022
Yun-Kim
reviewed
Nov 21, 2022
Yun-Kim
left a comment
Yun-Kim
left a comment
Contributor
There was a problem hiding this comment.
LGTM, should be good to merge once the conflict is fixed and the release note is changed profiler --> profiling 😄
Yun-Kim
previously requested changes
Nov 28, 2022
This fixes the profiler to support Python 3.11. The main issues came from the stack exception profiler where: 1. The exc_value was not checked entirely, casting in a wrong type 2. A reference leak to the exc_tb could happen This also changes the minimum version of tenacity to 7 so it does not use the deprecated asyncio.coroutine anymore.
Kyle-Verhoog
reviewed
Dec 6, 2022
Kyle-Verhoog
previously approved these changes
Dec 6, 2022
|
I really look forward having the profiler for python 3.11! when can I expect this released ? |
Kyle-Verhoog
reviewed
Dec 9, 2022
Kyle-Verhoog
approved these changes
Dec 9, 2022
brettlangdon
approved these changes
Dec 9, 2022
brettlangdon
enabled auto-merge (squash)
December 9, 2022 23:54
11 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the profiler to support Python 3.11.
The main issues came from the stack exception profiler where:
This also changes the minimum version of tenacity to 7 so it does not use the
deprecated asyncio.coroutine anymore.