fix(azure_cosmos): normalize cosmos resources by pablomartinezbernardo · Pull Request #18258 · DataDog/dd-trace-py

pablomartinezbernardo · 2026-05-25T10:39:31Z

Description

Normalize CosmosDB resource URI IDs to reduce resource cardinality. Resource cardinality should be bound, as it affects metrics and UI. Normalize even segments from the URI that are not the database id or the collection id.

Replicates dotnet fix DataDog/dd-trace-dotnet#8541

Testing

Unit tests

Risks

Users with dashboards and monitors configured on the resource of these spans. Changed without possibility to fall back to the old behavior because this is a bug:

Unbounded card can be problematic
Filters/groups on resources containing IDs are pretty much useless

datadog-prod-us1-4 · 2026-05-25T10:39:37Z

Tests

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 8 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux: [amd64, cp315-cp315, v113741491-d2b8243-musllinux_1_2_x86_64]

🔧 Fix in code (Fix with Cursor).
NotImplementedError: This version of CPython is not supported yet

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1]

🔄 Retry job. This looks flaky and may succeed on retry.
Unable to schedule job due to all nodes being unschedulable: insufficient memory, CPU, and untolerated taints.

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741589-d2b8243-musllinux_1_2_aarch64, 1]

🔄 Retry job. This looks flaky and may succeed on retry.
Error cloning repository: repository not found in cache.

View all 8 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: c869b5e | Docs | Datadog PR Page | Give us feedback!}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d359ce924

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

cit-pr-commenter-54b7da · 2026-05-25T10:52:45Z

Codeowners resolved as

ddtrace/_trace/trace_handlers.py                                        @DataDog/apm-sdk-capabilities-python @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/azure_cosmos/utils.py                          @DataDog/apm-core-python @DataDog/apm-idm-python
releasenotes/notes/azure-cosmos-normalize-resource-uri-9b73444519e403c4.yaml  @DataDog/apm-python
tests/contrib/azure_cosmos/test_normalize_resource_uri.py               @DataDog/apm-core-python @DataDog/apm-idm-python
tests/snapshots/tests.contrib.azure_cosmos.test_azure_cosmos_snapshot.test_cosmos_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.azure_cosmos.test_azure_cosmos_snapshot.test_cosmos_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.azure_cosmos.test_azure_cosmos_snapshot.test_cosmos_sync.json  @DataDog/apm-python

pr-commenter · 2026-05-25T11:11:09Z

Benchmarks

Benchmark execution time: 2026-05-28 08:09:33

Comparing candidate commit c869b5e in PR branch pmartinez/cosmosdb-resource with baseline commit d6198b1 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 384 metrics, 9 unstable metrics.

scenario:span-start

🟥 execution_time [+1.335ms; +1.492ms] or [+8.789%; +9.825%]

scenario:telemetryaddmetric-1-count-metric-1-times

🟥 execution_time [+241.572ns; +280.364ns] or [+11.494%; +13.340%]

brettlangdon

just a question, not a blocker, otherwise lgtm

pablomartinezbernardo · 2026-05-28T07:03:31Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-05-28T07:03:36Z

View all feedbacks in Devflow UI.

2026-05-28 07:03:35 UTC ℹ️ Start processing command /merge

2026-05-28 07:03:41 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 53m (p90).

2026-05-28 07:40:30 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 9dcb913:

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Normalize cosmos resources

3d359ce

pablomartinezbernardo requested review from a team as code owners May 25, 2026 10:39

pablomartinezbernardo requested review from brettlangdon and mabdinur May 25, 2026 10:39

pablomartinezbernardo requested a review from quinna-h May 25, 2026 10:39

chatgpt-codex-connector Bot reviewed May 25, 2026

View reviewed changes

Comment thread ddtrace/contrib/internal/azure_cosmos/utils.py Outdated

Reflect the possibility that the resource starts with a leading slash

e8abbec

brettlangdon approved these changes May 27, 2026

View reviewed changes

Comment thread ddtrace/contrib/internal/azure_cosmos/utils.py

Merge branch 'main' into pmartinez/cosmosdb-resource

c869b5e

gh-worker-dd-mergequeue-cf854d Bot merged commit 35dcf14 into main May 28, 2026
1161 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the pmartinez/cosmosdb-resource branch May 28, 2026 08:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(azure_cosmos): normalize cosmos resources#18258

fix(azure_cosmos): normalize cosmos resources#18258
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
pmartinez/cosmosdb-resource

pablomartinezbernardo commented May 25, 2026

Uh oh!

datadog-prod-us1-4 Bot commented May 25, 2026 •

edited by datadog-prod-us1-5 Bot

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

cit-pr-commenter-54b7da Bot commented May 25, 2026 •

edited

Loading

Uh oh!

pr-commenter Bot commented May 25, 2026 •

edited

Loading

Uh oh!

brettlangdon left a comment

Uh oh!

Uh oh!

pablomartinezbernardo commented May 28, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented May 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pablomartinezbernardo commented May 25, 2026

Description

Testing

Risks

Uh oh!

datadog-prod-us1-4 Bot commented May 25, 2026 • edited by datadog-prod-us1-5 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cit-pr-commenter-54b7da Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codeowners resolved as

Uh oh!

pr-commenter Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

scenario:span-start

scenario:telemetryaddmetric-1-count-metric-1-times

Uh oh!

brettlangdon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pablomartinezbernardo commented May 28, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

datadog-prod-us1-4 Bot commented May 25, 2026 •

edited by datadog-prod-us1-5 Bot

Loading

cit-pr-commenter-54b7da Bot commented May 25, 2026 •

edited

Loading

pr-commenter Bot commented May 25, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented May 28, 2026 •

edited

Loading