feat(process_tags): enable process tags by default#16743
feat(process_tags): enable process tags by default#16743gh-worker-dd-mergequeue-cf854d[bot] merged 10 commits into
Conversation
Codeowners resolved as |
This comment has been minimized.
This comment has been minimized.
Performance SLOsComparing candidate dubloom/enable-process-by-default (4cbc429) with baseline main (599a002) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 103.637µs (SLO: <130.000µs 📉 -20.3%) vs baseline: +2.7% Memory: ✅ 43.647MB (SLO: <46.000MB -5.1%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 100.326µs (SLO: <130.000µs 📉 -22.8%) vs baseline: -1.5% Memory: ✅ 43.686MB (SLO: <46.000MB -5.0%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 28.317µs (SLO: <40.000µs 📉 -29.2%) vs baseline: -0.5% Memory: ✅ 43.745MB (SLO: <46.000MB -4.9%) vs baseline: +4.8% ✅ add_noaspectTime: ✅ 48.845µs (SLO: <70.000µs 📉 -30.2%) vs baseline: -0.1% Memory: ✅ 43.824MB (SLO: <46.000MB -4.7%) vs baseline: +5.1% ✅ bytearray_aspectTime: ✅ 253.457µs (SLO: <400.000µs 📉 -36.6%) vs baseline: +0.2% Memory: ✅ 43.686MB (SLO: <46.000MB -5.0%) vs baseline: +4.6% ✅ bytearray_extend_aspectTime: ✅ 644.709µs (SLO: <800.000µs 📉 -19.4%) vs baseline: +0.4% Memory: ✅ 43.726MB (SLO: <46.000MB -4.9%) vs baseline: +5.0% ✅ bytearray_extend_noaspectTime: ✅ 267.051µs (SLO: <400.000µs 📉 -33.2%) vs baseline: ~same Memory: ✅ 43.922MB (SLO: <46.000MB -4.5%) vs baseline: +5.3% ✅ bytearray_noaspectTime: ✅ 141.770µs (SLO: <300.000µs 📉 -52.7%) vs baseline: +0.1% Memory: ✅ 43.686MB (SLO: <46.000MB -5.0%) vs baseline: +4.6% ✅ bytes_aspectTime: ✅ 216.974µs (SLO: <300.000µs 📉 -27.7%) vs baseline: -1.2% Memory: ✅ 43.647MB (SLO: <46.000MB -5.1%) vs baseline: +4.7% ✅ bytes_noaspectTime: ✅ 136.110µs (SLO: <200.000µs 📉 -31.9%) vs baseline: +1.4% Memory: ✅ 43.726MB (SLO: <46.000MB -4.9%) vs baseline: +4.8% ✅ bytesio_aspectTime: ✅ 3.779ms (SLO: <5.000ms 📉 -24.4%) vs baseline: +0.8% Memory: ✅ 43.647MB (SLO: <46.000MB -5.1%) vs baseline: +4.7% ✅ bytesio_noaspectTime: ✅ 317.292µs (SLO: <420.000µs 📉 -24.5%) vs baseline: +0.1% Memory: ✅ 43.804MB (SLO: <46.000MB -4.8%) vs baseline: +5.2% ✅ capitalize_aspectTime: ✅ 89.133µs (SLO: <300.000µs 📉 -70.3%) vs baseline: +1.1% Memory: ✅ 43.844MB (SLO: <46.000MB -4.7%) vs baseline: +5.3% ✅ capitalize_noaspectTime: ✅ 262.050µs (SLO: <300.000µs 📉 -12.7%) vs baseline: +4.3% Memory: ✅ 43.686MB (SLO: <46.000MB -5.0%) vs baseline: +4.4% ✅ casefold_aspectTime: ✅ 88.395µs (SLO: <500.000µs 📉 -82.3%) vs baseline: ~same Memory: ✅ 43.667MB (SLO: <46.000MB -5.1%) vs baseline: +4.7% ✅ casefold_noaspectTime: ✅ 303.939µs (SLO: <500.000µs 📉 -39.2%) vs baseline: -0.3% Memory: ✅ 43.863MB (SLO: <46.000MB -4.6%) vs baseline: +5.2% ✅ decode_aspectTime: ✅ 86.511µs (SLO: <100.000µs 📉 -13.5%) vs baseline: -0.8% Memory: ✅ 43.706MB (SLO: <46.000MB -5.0%) vs baseline: +5.0% ✅ decode_noaspectTime: ✅ 154.340µs (SLO: <210.000µs 📉 -26.5%) vs baseline: -0.4% Memory: ✅ 43.942MB (SLO: <46.000MB -4.5%) vs baseline: +5.1% ✅ encode_aspectTime: ✅ 84.284µs (SLO: <200.000µs 📉 -57.9%) vs baseline: -0.1% Memory: ✅ 43.745MB (SLO: <46.000MB -4.9%) vs baseline: +5.0% ✅ encode_noaspectTime: ✅ 140.628µs (SLO: <200.000µs 📉 -29.7%) vs baseline: -1.8% Memory: ✅ 43.863MB (SLO: <46.000MB -4.6%) vs baseline: +5.4% ✅ format_aspectTime: ✅ 14.586ms (SLO: <19.200ms 📉 -24.0%) vs baseline: ~same Memory: ✅ 43.765MB (SLO: <46.000MB -4.9%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 16.386ms (SLO: <21.500ms 📉 -23.8%) vs baseline: -0.2% Memory: ✅ 43.785MB (SLO: <46.000MB -4.8%) vs baseline: +4.8% ✅ format_map_noaspectTime: ✅ 366.023µs (SLO: <500.000µs 📉 -26.8%) vs baseline: -0.2% Memory: ✅ 43.804MB (SLO: <46.000MB -4.8%) vs baseline: +5.1% ✅ format_noaspectTime: ✅ 306.754µs (SLO: <500.000µs 📉 -38.6%) vs baseline: ~same Memory: ✅ 43.706MB (SLO: <46.000MB -5.0%) vs baseline: +4.8% ✅ index_aspectTime: ✅ 134.645µs (SLO: <300.000µs 📉 -55.1%) vs baseline: +8.8% Memory: ✅ 43.765MB (SLO: <46.000MB -4.9%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 40.494µs (SLO: <300.000µs 📉 -86.5%) vs baseline: +0.9% Memory: ✅ 43.765MB (SLO: <46.000MB -4.9%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 213.701µs (SLO: <300.000µs 📉 -28.8%) vs baseline: ~same Memory: ✅ 43.667MB (SLO: <46.000MB -5.1%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 146.887µs (SLO: <300.000µs 📉 -51.0%) vs baseline: +2.5% Memory: ✅ 43.726MB (SLO: <46.000MB -4.9%) vs baseline: +4.6% ✅ ljust_aspectTime: ✅ 497.319µs (SLO: <700.000µs 📉 -29.0%) vs baseline: -0.4% Memory: ✅ 43.745MB (SLO: <46.000MB -4.9%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 272.738µs (SLO: <300.000µs -9.1%) vs baseline: +5.9% Memory: ✅ 43.863MB (SLO: <46.000MB -4.6%) vs baseline: +4.8% ✅ lower_aspectTime: ✅ 295.564µs (SLO: <500.000µs 📉 -40.9%) vs baseline: -0.1% Memory: ✅ 43.706MB (SLO: <46.000MB -5.0%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 238.175µs (SLO: <300.000µs 📉 -20.6%) vs baseline: +0.8% Memory: ✅ 43.785MB (SLO: <46.000MB -4.8%) vs baseline: +4.8% ✅ lstrip_aspectTime: ✅ 0.271ms (SLO: <3.000ms 📉 -91.0%) vs baseline: +0.7% Memory: ✅ 43.706MB (SLO: <46.000MB -5.0%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 0.177ms (SLO: <3.000ms 📉 -94.1%) vs baseline: -0.4% Memory: ✅ 44.001MB (SLO: <46.000MB -4.3%) vs baseline: +5.3% ✅ modulo_aspectTime: ✅ 14.290ms (SLO: <18.750ms 📉 -23.8%) vs baseline: +0.1% Memory: ✅ 43.824MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.762ms (SLO: <19.350ms 📉 -23.7%) vs baseline: ~same Memory: ✅ 43.804MB (SLO: <46.000MB -4.8%) vs baseline: +4.8% ✅ modulo_aspect_for_bytesTime: ✅ 14.406ms (SLO: <18.900ms 📉 -23.8%) vs baseline: +0.2% Memory: ✅ 43.863MB (SLO: <46.000MB -4.6%) vs baseline: +4.4% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.613ms (SLO: <19.150ms 📉 -23.7%) vs baseline: +0.3% Memory: ✅ 43.863MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ modulo_noaspectTime: ✅ 0.363ms (SLO: <3.000ms 📉 -87.9%) vs baseline: ~same Memory: ✅ 43.785MB (SLO: <46.000MB -4.8%) vs baseline: +4.8% ✅ replace_aspectTime: ✅ 18.326ms (SLO: <24.000ms 📉 -23.6%) vs baseline: -0.7% Memory: ✅ 43.726MB (SLO: <46.000MB -4.9%) vs baseline: +4.5% ✅ replace_noaspectTime: ✅ 280.139µs (SLO: <300.000µs -6.6%) vs baseline: -0.9% Memory: ✅ 43.765MB (SLO: <46.000MB -4.9%) vs baseline: +4.7% ✅ repr_aspectTime: ✅ 316.263µs (SLO: <420.000µs 📉 -24.7%) vs baseline: ~same Memory: ✅ 43.726MB (SLO: <46.000MB -4.9%) vs baseline: +5.0% ✅ repr_noaspectTime: ✅ 46.614µs (SLO: <90.000µs 📉 -48.2%) vs baseline: -0.7% Memory: ✅ 43.765MB (SLO: <46.000MB -4.9%) vs baseline: +4.7% ✅ rstrip_aspectTime: ✅ 386.533µs (SLO: <500.000µs 📉 -22.7%) vs baseline: +0.2% Memory: ✅ 43.804MB (SLO: <46.000MB -4.8%) vs baseline: +5.1% ✅ rstrip_noaspectTime: ✅ 184.009µs (SLO: <300.000µs 📉 -38.7%) vs baseline: ~same Memory: ✅ 43.824MB (SLO: <46.000MB -4.7%) vs baseline: +5.1% ✅ slice_aspectTime: ✅ 180.964µs (SLO: <300.000µs 📉 -39.7%) vs baseline: +0.2% Memory: ✅ 43.726MB (SLO: <46.000MB -4.9%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 54.268µs (SLO: <90.000µs 📉 -39.7%) vs baseline: +1.1% Memory: ✅ 43.883MB (SLO: <46.000MB -4.6%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 4.456ms (SLO: <5.000ms 📉 -10.9%) vs baseline: 📈 +17.2% Memory: ✅ 43.686MB (SLO: <46.000MB -5.0%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 349.134µs (SLO: <500.000µs 📉 -30.2%) vs baseline: ~same Memory: ✅ 43.745MB (SLO: <46.000MB -4.9%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 271.983µs (SLO: <350.000µs 📉 -22.3%) vs baseline: +0.2% Memory: ✅ 43.765MB (SLO: <46.000MB -4.9%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 175.973µs (SLO: <240.000µs 📉 -26.7%) vs baseline: +0.5% Memory: ✅ 43.863MB (SLO: <46.000MB -4.6%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 334.108µs (SLO: <500.000µs 📉 -33.2%) vs baseline: +0.1% Memory: ✅ 43.667MB (SLO: <46.000MB -5.1%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 272.962µs (SLO: <400.000µs 📉 -31.8%) vs baseline: +0.8% Memory: ✅ 43.863MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 319.380µs (SLO: <500.000µs 📉 -36.1%) vs baseline: -0.5% Memory: ✅ 43.726MB (SLO: <46.000MB -4.9%) vs baseline: +5.0% ✅ title_noaspectTime: ✅ 260.141µs (SLO: <400.000µs 📉 -35.0%) vs baseline: +0.2% Memory: ✅ 43.922MB (SLO: <46.000MB -4.5%) vs baseline: +5.3% ✅ translate_aspectTime: ✅ 488.126µs (SLO: <700.000µs 📉 -30.3%) vs baseline: -0.2% Memory: ✅ 43.706MB (SLO: <46.000MB -5.0%) vs baseline: +4.9% ✅ translate_noaspectTime: ✅ 420.196µs (SLO: <500.000µs 📉 -16.0%) vs baseline: -1.6% Memory: ✅ 43.686MB (SLO: <46.000MB -5.0%) vs baseline: +4.7% ✅ upper_aspectTime: ✅ 293.667µs (SLO: <500.000µs 📉 -41.3%) vs baseline: -0.6% Memory: ✅ 43.726MB (SLO: <46.000MB -4.9%) vs baseline: +5.0% ✅ upper_noaspectTime: ✅ 238.291µs (SLO: <400.000µs 📉 -40.4%) vs baseline: +0.3% Memory: ✅ 43.726MB (SLO: <46.000MB -4.9%) vs baseline: +4.7% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 531.042µs (SLO: <700.000µs 📉 -24.1%) vs baseline: 📈 +26.0% Memory: ✅ 43.581MB (SLO: <46.000MB -5.3%) vs baseline: +4.5% ✅ ospathbasename_noaspectTime: ✅ 431.878µs (SLO: <700.000µs 📉 -38.3%) vs baseline: +0.3% Memory: ✅ 43.750MB (SLO: <46.000MB -4.9%) vs baseline: +5.2% ✅ ospathjoin_aspectTime: ✅ 629.832µs (SLO: <700.000µs 📉 -10.0%) vs baseline: +0.6% Memory: ✅ 43.645MB (SLO: <46.000MB -5.1%) vs baseline: +4.6% ✅ ospathjoin_noaspectTime: ✅ 637.803µs (SLO: <700.000µs -8.9%) vs baseline: -0.3% Memory: ✅ 43.666MB (SLO: <46.000MB -5.1%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 351.122µs (SLO: <700.000µs 📉 -49.8%) vs baseline: -0.3% Memory: ✅ 43.641MB (SLO: <46.000MB -5.1%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 359.914µs (SLO: <700.000µs 📉 -48.6%) vs baseline: +0.8% Memory: ✅ 43.606MB (SLO: <46.000MB -5.2%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 488.025µs (SLO: <700.000µs 📉 -30.3%) vs baseline: -0.2% Memory: ✅ 43.749MB (SLO: <46.000MB -4.9%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 501.229µs (SLO: <700.000µs 📉 -28.4%) vs baseline: +0.6% Memory: ✅ 43.663MB (SLO: <46.000MB -5.1%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 378.058µs (SLO: <700.000µs 📉 -46.0%) vs baseline: +0.5% Memory: ✅ 43.709MB (SLO: <46.000MB -5.0%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 72.255µs (SLO: <700.000µs 📉 -89.7%) vs baseline: -0.6% Memory: ✅ 43.666MB (SLO: <46.000MB -5.1%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 461.353µs (SLO: <700.000µs 📉 -34.1%) vs baseline: +1.3% Memory: ✅ 43.682MB (SLO: <46.000MB -5.0%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 463.978µs (SLO: <700.000µs 📉 -33.7%) vs baseline: -0.2% Memory: ✅ 43.676MB (SLO: <46.000MB -5.1%) vs baseline: +5.1% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.407µs (SLO: <20.000µs 📉 -88.0%) vs baseline: 📈 +12.7% Memory: ✅ 36.785MB (SLO: <38.000MB -3.2%) vs baseline: +5.1% ✅ 1-count-metrics-100-timesTime: ✅ 153.945µs (SLO: <220.000µs 📉 -30.0%) vs baseline: -1.7% Memory: ✅ 36.667MB (SLO: <38.000MB -3.5%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 2.489µs (SLO: <20.000µs 📉 -87.6%) vs baseline: +1.0% Memory: ✅ 36.707MB (SLO: <38.000MB -3.4%) vs baseline: +4.8% ✅ 1-distribution-metrics-100-timesTime: ✅ 164.840µs (SLO: <230.000µs 📉 -28.3%) vs baseline: +0.3% Memory: ✅ 36.687MB (SLO: <38.000MB -3.5%) vs baseline: +4.6% ✅ 1-gauge-metric-1-timesTime: ✅ 1.982µs (SLO: <20.000µs 📉 -90.1%) vs baseline: -1.4% Memory: ✅ 36.785MB (SLO: <38.000MB -3.2%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.201µs (SLO: <150.000µs -9.2%) vs baseline: -0.2% Memory: ✅ 36.648MB (SLO: <38.000MB -3.6%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 2.286µs (SLO: <20.000µs 📉 -88.6%) vs baseline: +1.5% Memory: ✅ 36.805MB (SLO: <38.000MB -3.1%) vs baseline: +4.8% ✅ 1-rate-metrics-100-timesTime: ✅ 169.549µs (SLO: <250.000µs 📉 -32.2%) vs baseline: -0.3% Memory: ✅ 36.766MB (SLO: <38.000MB -3.2%) vs baseline: +4.5% ✅ 100-count-metrics-100-timesTime: ✅ 15.514ms (SLO: <22.000ms 📉 -29.5%) vs baseline: -0.8% Memory: ✅ 36.628MB (SLO: <38.000MB -3.6%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 1.748ms (SLO: <2.550ms 📉 -31.4%) vs baseline: +0.2% Memory: ✅ 36.667MB (SLO: <38.000MB -3.5%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.395ms (SLO: <1.550ms 📉 -10.0%) vs baseline: -0.5% Memory: ✅ 36.707MB (SLO: <38.000MB -3.4%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 1.777ms (SLO: <2.550ms 📉 -30.3%) vs baseline: +1.0% Memory: ✅ 36.687MB (SLO: <38.000MB -3.5%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 3.660µs (SLO: <20.000µs 📉 -81.7%) vs baseline: +0.6% Memory: ✅ 36.648MB (SLO: <38.000MB -3.6%) vs baseline: +4.4% ✅ flush-100-metricsTime: ✅ 176.937µs (SLO: <250.000µs 📉 -29.2%) vs baseline: +0.1% Memory: ✅ 36.766MB (SLO: <38.000MB -3.2%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.207ms (SLO: <2.500ms 📉 -11.7%) vs baseline: -0.6% Memory: ✅ 37.493MB (SLO: <38.750MB -3.2%) vs baseline: +4.9% 🟡 Near SLO Breach (3 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.597ms (SLO: <22.300ms 📉 -12.1%) vs baseline: -0.1% Memory: ✅ 68.783MB (SLO: <73.500MB -6.4%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.385ms (SLO: <1.450ms -4.5%) vs baseline: -0.2% Memory: ✅ 66.667MB (SLO: <71.500MB -6.8%) vs baseline: +4.7% ✅ iastTime: ✅ 19.642ms (SLO: <22.250ms 📉 -11.7%) vs baseline: ~same Memory: ✅ 68.842MB (SLO: <75.000MB -8.2%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.152ms (SLO: <16.550ms -8.4%) vs baseline: -0.2% Memory: ✅ 60.167MB (SLO: <61.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 19.568ms (SLO: <21.750ms 📉 -10.0%) vs baseline: -0.1% Memory: ✅ 68.842MB (SLO: <73.500MB -6.3%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 20.115ms (SLO: <28.200ms 📉 -28.7%) vs baseline: +1.6% Memory: ✅ 68.593MB (SLO: <75.000MB -8.5%) vs baseline: +4.9% ✅ tracerTime: ✅ 19.541ms (SLO: <21.750ms 📉 -10.2%) vs baseline: -0.4% Memory: ✅ 68.744MB (SLO: <75.000MB -8.3%) vs baseline: +4.7% ✅ tracer-and-profilerTime: ✅ 21.092ms (SLO: <23.500ms 📉 -10.2%) vs baseline: +0.3% Memory: ✅ 70.306MB (SLO: <75.000MB -6.3%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.817ms (SLO: <21.500ms -7.8%) vs baseline: +0.9% Memory: ✅ 68.867MB (SLO: <75.000MB -8.2%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.762ms (SLO: <17.500ms -4.2%) vs baseline: -0.3% Memory: ✅ 68.754MB (SLO: <75.000MB -8.3%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 19.502ms (SLO: <21.750ms 📉 -10.3%) vs baseline: ~same Memory: ✅ 68.811MB (SLO: <72.500MB -5.1%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 17.580ms (SLO: <19.650ms 📉 -10.5%) vs baseline: -0.3% Memory: ✅ 68.803MB (SLO: <75.000MB -8.3%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 19.125ms (SLO: <20.100ms -4.9%) vs baseline: -0.6% Memory: ✅ 68.783MB (SLO: <75.000MB -8.3%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 19.327ms (SLO: <21.500ms 📉 -10.1%) vs baseline: ~same Memory: ✅ 68.783MB (SLO: <75.000MB -8.3%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 19.820ms (SLO: <22.000ms -9.9%) vs baseline: +2.0% Memory: ✅ 68.686MB (SLO: <73.500MB -6.5%) vs baseline: +4.6% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 3.443ms (SLO: <4.750ms 📉 -27.5%) vs baseline: +0.4% Memory: ✅ 56.281MB (SLO: <66.500MB 📉 -15.4%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 2.908ms (SLO: <6.750ms 📉 -56.9%) vs baseline: +0.5% Memory: ✅ 56.284MB (SLO: <66.500MB 📉 -15.4%) vs baseline: +5.0% ✅ appsec-telemetryTime: ✅ 3.446ms (SLO: <4.750ms 📉 -27.4%) vs baseline: +0.9% Memory: ✅ 56.300MB (SLO: <66.500MB 📉 -15.3%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.872ms (SLO: <2.000ms -6.4%) vs baseline: ~same Memory: ✅ 49.485MB (SLO: <51.500MB -3.9%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.861ms (SLO: <2.000ms -7.0%) vs baseline: ~same Memory: ✅ 46.122MB (SLO: <49.000MB -5.9%) vs baseline: +4.6% ✅ profilerTime: ✅ 1.905ms (SLO: <2.100ms -9.3%) vs baseline: -0.1% Memory: ✅ 52.435MB (SLO: <52.500MB 🟡 -0.1%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 3.410ms (SLO: <3.650ms -6.6%) vs baseline: -0.1% Memory: ✅ 56.260MB (SLO: <60.000MB -6.2%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.418ms (SLO: <3.650ms -6.4%) vs baseline: ~same Memory: ✅ 56.268MB (SLO: <60.000MB -6.2%) vs baseline: +5.0% ✅ tracer-nativeTime: ✅ 3.415ms (SLO: <3.650ms -6.4%) vs baseline: ~same Memory: ✅ 56.285MB (SLO: <60.000MB -6.2%) vs baseline: +5.0% 🟡 tracer - 6/6✅ largeTime: ✅ 31.291ms (SLO: <32.950ms -5.0%) vs baseline: ~same Memory: ✅ 37.532MB (SLO: <39.250MB -4.4%) vs baseline: +4.7% ✅ mediumTime: ✅ 3.095ms (SLO: <3.200ms -3.3%) vs baseline: +0.2% Memory: ✅ 36.255MB (SLO: <38.750MB -6.4%) vs baseline: +4.7% ✅ smallTime: ✅ 362.603µs (SLO: <370.000µs 🟡 -2.0%) vs baseline: +3.5% Memory: ✅ 36.313MB (SLO: <38.750MB -6.3%) vs baseline: +4.9%
|
9a20622 to
3b84326
Compare
01ecc37 to
af6c479
Compare
dubloom
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af6c479ca3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
5ee29d1 to
7f5d912
Compare
## Description This PR: - Enables process tags by default. - **VERY IMPORTANT** Removes duplication of process tags environment variable declaration (the declaration resides in a separate file for circular import) - Edit tests as we don't need to explicitly enable the feature anymore. - Ignores process_tags in snapshot except for process tags testing. **Important**: a PR was previously opened to enable process tags by default and a comment was talking about adding process_tags in all snapshots instead of ignoring. This is a good idea, however as process_tags differ between CI and local testing, this is not trivial. If we still want to do that, i'd like to do it in a follow up PR to not block the enablement. ## Testing No tests were added as we lean on existing test. We just added a test to check the feature can indeed be deactivated. ## Risks Probably none, the feature was dogfooded on AI gateway on staging. Co-authored-by: louis.tricot <[email protected]>
7 participants
Description
This PR:
Important: a PR was previously opened to enable process tags by default and a comment was talking about adding process_tags in all snapshots instead of ignoring.
This is a good idea, however as process_tags differ between CI and local testing, this is not trivial. If we still want to do that, i'd like to do it in a follow up PR to not block the enablement.
Testing
No tests were added as we lean on existing test. We just added a test to check the feature can indeed be deactivated.
Risks
Probably none, the feature was dogfooded on AI gateway on staging.