chore(waf): fix block_config compatibility#15208
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 3 ms. The average import time from base is: 243 ± 4 ms. The import time difference between this PR and base is: -5.1 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate avara1986/APPSEC-59959_block_config (b920697) with baseline main (1c3361c) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.453ms (SLO: <22.300ms -8.3%) vs baseline: +0.2% Memory: ✅ 66.072MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.1% ✅ exception-replay-enabledTime: ✅ 1.333ms (SLO: <1.450ms -8.0%) vs baseline: -0.3% Memory: ✅ 64.125MB (SLO: <67.000MB -4.3%) vs baseline: +4.7% ✅ iastTime: ✅ 20.426ms (SLO: <22.250ms -8.2%) vs baseline: -0.3% Memory: ✅ 65.944MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ profilerTime: ✅ 15.594ms (SLO: <16.550ms -5.8%) vs baseline: +0.4% Memory: ✅ 53.906MB (SLO: <54.500MB 🟡 -1.1%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 20.515ms (SLO: <21.750ms -5.7%) vs baseline: -0.2% Memory: ✅ 66.119MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 25.034ms (SLO: <28.200ms 📉 -11.2%) vs baseline: -1.2% Memory: ✅ 67.144MB (SLO: <69.500MB -3.4%) vs baseline: +4.9% ✅ tracerTime: ✅ 20.472ms (SLO: <21.750ms -5.9%) vs baseline: -0.2% Memory: ✅ 66.076MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.722ms (SLO: <23.500ms -3.3%) vs baseline: +0.1% Memory: ✅ 67.979MB (SLO: <68.000MB 🟡 ~same) vs baseline: +5.1% ✅ tracer-dont-create-db-spansTime: ✅ 19.319ms (SLO: <21.500ms 📉 -10.1%) vs baseline: -0.2% Memory: ✅ 65.939MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 16.644ms (SLO: <17.500ms -4.9%) vs baseline: +0.3% Memory: ✅ 65.928MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 20.415ms (SLO: <21.750ms -6.1%) vs baseline: -0.4% Memory: ✅ 67.987MB (SLO: <72.500MB -6.2%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.437ms (SLO: <19.650ms -6.2%) vs baseline: ~same Memory: ✅ 65.987MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.748ms (SLO: <20.100ms -6.7%) vs baseline: ~same Memory: ✅ 65.993MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +5.1% ✅ tracer-no-middlewareTime: ✅ 20.141ms (SLO: <21.500ms -6.3%) vs baseline: ~same Memory: ✅ 66.022MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.7% ✅ tracer-no-templatesTime: ✅ 20.228ms (SLO: <22.000ms -8.1%) vs baseline: ~same Memory: ✅ 66.021MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.151ms (SLO: <19.850ms -8.6%) vs baseline: +0.3% Memory: ✅ 66.111MB (SLO: <66.500MB 🟡 -0.6%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 18.224ms (SLO: <19.400ms -6.1%) vs baseline: +0.9% Memory: ✅ 66.159MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 18.063ms (SLO: <19.450ms -7.1%) vs baseline: ~same Memory: ✅ 65.824MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +4.8% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.070ms (SLO: <2.300ms -10.0%) vs baseline: +0.5% Memory: ✅ 52.376MB (SLO: <53.500MB -2.1%) vs baseline: +4.4% ✅ errortracking-enabled-userTime: ✅ 2.072ms (SLO: <2.250ms -7.9%) vs baseline: +0.2% Memory: ✅ 52.514MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ tracer-enabledTime: ✅ 2.073ms (SLO: <2.300ms -9.9%) vs baseline: +0.6% Memory: ✅ 52.376MB (SLO: <53.500MB -2.1%) vs baseline: +4.5% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.589ms (SLO: <4.750ms -3.4%) vs baseline: -1.0% Memory: ✅ 62.361MB (SLO: <65.000MB -4.1%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.628ms (SLO: <6.750ms 🟡 -1.8%) vs baseline: -0.4% Memory: ✅ 62.284MB (SLO: <65.000MB -4.2%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.599ms (SLO: <4.750ms -3.2%) vs baseline: -0.3% Memory: ✅ 62.362MB (SLO: <65.000MB -4.1%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.855ms (SLO: <2.000ms -7.3%) vs baseline: -0.5% Memory: ✅ 45.187MB (SLO: <47.000MB -3.9%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: -0.5% Memory: ✅ 42.082MB (SLO: <49.000MB 📉 -14.1%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -9.0%) vs baseline: -0.4% Memory: ✅ 46.676MB (SLO: <47.000MB 🟡 -0.7%) vs baseline: +5.1% ✅ resource-renamingTime: ✅ 3.370ms (SLO: <3.650ms -7.7%) vs baseline: -0.3% Memory: ✅ 52.571MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.345ms (SLO: <3.650ms -8.4%) vs baseline: -0.9% Memory: ✅ 52.562MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.353ms (SLO: <3.650ms -8.1%) vs baseline: -0.4% Memory: ✅ 54.310MB (SLO: <60.000MB -9.5%) vs baseline: +4.8% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 308.880ms (SLO: <320.950ms -3.8%) vs baseline: +0.3% Memory: ✅ 32.657MB (SLO: <34.500MB -5.3%) vs baseline: +4.7% ✅ deep-profiledTime: ✅ 328.360ms (SLO: <359.150ms -8.6%) vs baseline: +0.2% Memory: ✅ 38.469MB (SLO: <39.000MB 🟡 -1.4%) vs baseline: +6.8% ✅ mediumTime: ✅ 7.009ms (SLO: <7.400ms -5.3%) vs baseline: ~same Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ✅ shallowTime: ✅ 0.948ms (SLO: <1.050ms -9.7%) vs baseline: +0.9% Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.9%
|
Adds a
.get()method to theBlock_configclass to restore dictionary-like API compatibility broken by PR #15042, fixing Lambda integration failures.PR #15042 changed
Block_configfrom a dictionary to a class, introducing a breaking API change that caused Lambda integration to fail with:Rollback this ST PR after the merge DataDog/system-tests@f87f4dd
APPSEC-59959