Skip to content

chore(crashtracker): add required backend tags#10199

Merged
sanchda merged 8 commits into
mainfrom
08-13-chore_crashtracker_add_required_backend_tags
Aug 14, 2024
Merged

chore(crashtracker): add required backend tags#10199
sanchda merged 8 commits into
mainfrom
08-13-chore_crashtracker_add_required_backend_tags

Conversation

@sanchda

@sanchda sanchda commented Aug 13, 2024 •
edited by taegyunkim
Loading

Copy link
Copy Markdown
Contributor

This adds two new tags to the crashtracker. These tags will not be required in an upcoming version of libdatadog, but that version doesn't exist yet, so here we are.

There's no need to document anything in a changelog since this feature isn't customer-impacting. It just makes it easier for us to build dashboards on the backend. :)

PROF-10357

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@sanchda Graphite App

sanchda commented Aug 13, 2024

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sanchda and the rest of your teammates on Graphite Graphite

@github-actions

github-actions Bot commented Aug 13, 2024

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/datadog/profiling/dd_wrapper/include/constants.hpp     @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/libdatadog_helpers.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/crashtracker.cpp      @DataDog/profiling-python
tests/internal/crashtracker/test_crashtracker.py                        @DataDog/apm-core-python

@sanchda
sanchda marked this pull request as ready for review August 13, 2024 15:17
@sanchda
sanchda requested review from a team as code owners August 13, 2024 15:17
@sanchda
sanchda requested a review from erikayasuda August 13, 2024 15:17
@sanchda sanchda added changelog/no-changelog A changelog entry is not required for this PR. backport 2.10 labels Aug 13, 2024
@sanchda
sanchda force-pushed the 08-13-chore_crashtracker_add_required_backend_tags branch from eeff9c8 to 5c436eb Compare August 13, 2024 15:21
@sanchda
sanchda enabled auto-merge (squash) August 13, 2024 15:28
@sanchda sanchda closed this Aug 13, 2024
auto-merge was automatically disabled August 13, 2024 15:28

Pull request was closed

@sanchda sanchda reopened this Aug 13, 2024
@sanchda
sanchda enabled auto-merge (squash) August 13, 2024 15:28
@datadog-dd-trace-py-rkomorn

datadog-dd-trace-py-rkomorn Bot commented Aug 13, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: 08-13-chore_crashtracker_add_required_backend_tags
Commit report: 108ed8c
Test service: dd-trace-py

✅ 0 Failed, 413 Passed, 3397 Skipped, 33m 8.67s Total duration (56m 14.99s time saved)

@pr-commenter

pr-commenter Bot commented Aug 13, 2024 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2024-08-14 18:45:53

Comparing candidate commit 1cfe3bc in PR branch 08-13-chore_crashtracker_add_required_backend_tags with baseline commit 00a66eb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@taegyunkim
taegyunkim force-pushed the 08-13-chore_crashtracker_add_required_backend_tags branch from 5c436eb to ee09b27 Compare August 13, 2024 18:36
@erikayasuda

erikayasuda commented Aug 14, 2024

Copy link
Copy Markdown
Collaborator

@sanchda Do we need to backport this to 2.10? Isn't crashtracker is only available from 2.11?

@sanchda
sanchda merged commit a657198 into main Aug 14, 2024
@sanchda
sanchda deleted the 08-13-chore_crashtracker_add_required_backend_tags branch August 14, 2024 19:08
github-actions Bot pushed a commit that referenced this pull request Aug 14, 2024
@sanchda @github-actions
chore(crashtracker): add required backend tags (#10199)
7ef0693 
This adds two new tags to the crashtracker. These tags will not be
required in an upcoming version of libdatadog, but that version doesn't
exist yet, so here we are.

There's no need to document anything in a changelog since this feature
isn't customer-impacting. It just makes it easier for us to build
dashboards on the backend. :)

[PROF-10357]

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit a657198)
@github-actions github-actions Bot mentioned this pull request Aug 14, 2024
Merged
2 tasks
brettlangdon pushed a commit that referenced this pull request Aug 15, 2024
@sanchda @brettlangdon
chore(crashtracker): add required backend tags (#10199)
2045564 
This adds two new tags to the crashtracker. These tags will not be
required in an upcoming version of libdatadog, but that version doesn't
exist yet, so here we are.

There's no need to document anything in a changelog since this feature
isn't customer-impacting. It just makes it easier for us to build
dashboards on the backend. :)

[PROF-10357]

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
@ivoanjo ivoanjo mentioned this pull request Aug 15, 2024
Merged
sanchda added a commit that referenced this pull request Aug 15, 2024
@github-actions @sanchda
chore(crashtracker): add required backend tags [backport 2.11] (#10232)
ed52211 
Backport a657198 from #10199 to 2.11.

This adds two new tags to the crashtracker. These tags will not be
required in an upcoming version of libdatadog, but that version doesn't
exist yet, so here we are.

There's no need to document anything in a changelog since this feature
isn't customer-impacting. It just makes it easier for us to build
dashboards on the backend. :)

[PROF-10357]

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)


[PROF-10357]:
https://datadoghq.atlassian.net/browse/PROF-10357?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: David Sanchez <[email protected]>
ivoanjo added a commit to DataDog/dd-trace-rb that referenced this pull request Aug 15, 2024
@ivoanjo
[PROF-10241] Add extra tags to crash reports
64dfc9e 
**What does this PR do?**

This PR adds the following tags to crashtracker reports:
* language
* severity
* profiler_version

Severity is similar to what we do in Python in
DataDog/dd-trace-py#10199 .

The other two tags seem redundant, but right now if we don't pass
them as tags to libdatadog they don't get picked up correctly.

In the future, this won't be needed by libdatadog, but for now this
makes it easier for us to analyze reported crashes.

**Motivation:**

Improve crash reports.

**Additional Notes:**

N/A

**How to test the change?**

Change includes test coverage.
@ivoanjo ivoanjo mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taegyunkim taegyunkim taegyunkim approved these changes
@erikayasuda erikayasuda erikayasuda approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sanchda @erikayasuda @taegyunkim