fix(profiling): better autoinject detection [backport 2.11]#10119
Merged
Conversation
Previously, Profiling was injecting its own configuration during lib-injection handling. This was actually a little brittle. Instead, we move to a model where the profiler detects (in its normal configuration) whether the library was injected. Hopefully this is more durable and correct. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [X] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit d638a7b)
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
emmettbutler
approved these changes
Aug 7, 2024
Datadog ReportBranch report: ✅ 0 Failed, 118436 Passed, 60014 Skipped, 3h 39m 19.33s Total duration (5h 33m 47.84s time saved) |
sanchda
approved these changes
Aug 7, 2024
sanchda
enabled auto-merge (squash)
August 7, 2024 14:36
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.11 #10119 +/- ##
===========================================
- Coverage 34.18% 10.55% -23.64%
===========================================
Files 1385 1381 -4
Lines 129280 129237 -43
===========================================
- Hits 44191 13636 -30555
- Misses 85089 115601 +30512 ☔ View full report in Codecov by Sentry. |
auto-merge was automatically disabled
August 7, 2024 15:17
Pull request was closed
sanchda
enabled auto-merge (squash)
August 7, 2024 15:17
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport d638a7b from #9904 to 2.11.
PROF-10280
Previously, Profiling was injecting its own configuration during lib-injection handling. This was actually a little brittle.
Instead, we move to a model where the profiler detects (in its normal configuration) whether the library was injected. Hopefully this is more durable and correct.
Checklist
Reviewer Checklist