Sandbox Lumen on PHP 5#945
Merged
morrisonlevi merged 1 commit intomasterfrom Jul 6, 2020
Merged
Conversation
labbati
reviewed
Jul 6, 2020
Member
labbati
left a comment
labbati
left a comment
There was a problem hiding this comment.
Thanks @morrisonlevi, added a few comments/questions.
morrisonlevi
force-pushed
the
levi/build/sandbox-lumen-php5
branch
from
0e1f05e to
3ad071b
Compare
SammyK
reviewed
Jul 6, 2020
This adds un-necessary spans that can be removed once the non- tracing API is completed.
morrisonlevi
force-pushed
the
levi/build/sandbox-lumen-php5
branch
from
fd52dfa to
c9b681a
Compare
5 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds some un-necessary spans that can be removed once the non-tracing API is completed, but it is worth it to get off of
dd_trace.Readiness checklist
Reviewer checklist