Warn on dd_trace usage if DD_TRACE_WARN_LEGACY_DD_TRACE#941
Merged
morrisonlevi merged 4 commits intomasterfrom Jul 7, 2020
Merged
Warn on dd_trace usage if DD_TRACE_WARN_LEGACY_DD_TRACE#941morrisonlevi merged 4 commits intomasterfrom
morrisonlevi merged 4 commits intomasterfrom
Conversation
morrisonlevi
force-pushed
the
levi/build/legacy-warning
branch
3 times, most recently
from
7fb23f6 to
cd41eb8
Compare
morrisonlevi
force-pushed
the
levi/build/legacy-warning
branch
from
cd41eb8 to
c5454ea
Compare
morrisonlevi
changed the title
Collaborator
Author
morrisonlevi
force-pushed
the
levi/build/legacy-warning
branch
2 times, most recently
from
7303c43 to
3fa5abd
Compare
SammyK
previously approved these changes
Jul 6, 2020
morrisonlevi
force-pushed
the
levi/build/legacy-warning
branch
from
ca82a22 to
085d528
Compare
They cannot take any actions, so no need to link them to a page that will not help them.
SammyK
approved these changes
Jul 7, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the function
dd_traceis used, it will print a warning if:DD_TRACE_WARN_LEGACY_DD_TRACEis a truthy value like1ortrueCurrently, this still warns on PHP 5.4 as well, even though it does not have access to the sandboxed API.
Readiness checklist
Reviewer checklist