Extract ddtrace_sandbox_begin/ddtrace_sandbox_end helpers#940
Merged
morrisonlevi merged 1 commit intomasterfrom Jul 1, 2020
Merged
Extract ddtrace_sandbox_begin/ddtrace_sandbox_end helpers#940morrisonlevi merged 1 commit intomasterfrom
morrisonlevi merged 1 commit intomasterfrom
Conversation
morrisonlevi
added
the
c-extension
morrisonlevi
force-pushed
the
levi/build/sandbox
branch
3 times, most recently
from
3eb9529 to
873bd99
Compare
Most of the time the sandboxing code is the same, so let's de-duplicate it.
morrisonlevi
force-pushed
the
levi/build/sandbox
branch
from
873bd99 to
4e49428
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Most of the time the sandboxing code is the same, so let's de-duplicate it. We're going to start using it more too, for example:
Note that the PHP 7 curl handlers were only partly sandboxed as they don't expect exceptions from curl calls; they now backup the exception info anyway.
Readiness checklist
Reviewer checklist