Add a separate PHP 5 only file#938
Merged
morrisonlevi merged 2 commits intomasterfrom Jul 6, 2020
Merged
Conversation
morrisonlevi
force-pushed
the
levi/build/separate_php5_php
branch
from
7874849 to
3c4752c
Compare
labbati
force-pushed
the
levi/build/separate_php5_php
branch
from
3c4752c to
3ed95e9
Compare
morrisonlevi
changed the title
SammyK
previously approved these changes
Jul 2, 2020
Contributor
SammyK
left a comment
SammyK
left a comment
There was a problem hiding this comment.
Nice solution @morrisonlevi!
If the builtin webserver does not get output then it will sometimes sigsegv. We've hit this case many times. I think the only way we can stop hitting this case is to not use the built-in CLI webserver.
morrisonlevi
force-pushed
the
levi/build/separate_php5_php
branch
from
58fcea6 to
f667076
Compare
SammyK
approved these changes
Jul 6, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Sandbox cURL (PHP 5) #911 we added another function to
dd_init.phpand even though this function is needed only on PHP 5 it still increased memory usage on PHP 7. This PR adds aphp5.phpfile that PHP 5 specific functions can go into without affecting PHP 7 much.This PR also adds output to 2 more of our tests which were segfaulting because there wasn't any output. This is a known issue with the PHP CLI web server that isn't fixable; we have to keep mitigating it until we move off of this SAPI entirely.
Readiness checklist
Reviewer checklist