Skip to content

Add support for DD_TAGS, fallback to DD_TRACE_GLOBAL_TAGS#920

Merged
labbati merged 4 commits intomasterfrom
labbati/DD_TAGS
Jun 16, 2020
Merged

Add support for DD_TAGS, fallback to DD_TRACE_GLOBAL_TAGS#920
labbati merged 4 commits intomasterfrom
labbati/DD_TAGS

Conversation

@labbati
Copy link
Copy Markdown
Member

@labbati labbati commented Jun 12, 2020 •
edited by SammyK
Loading

Description

This PR adds support for DD_TAGS to configure global tags to be set on every span. This new environment variable replaces DD_TRACE_GLOBAL_TAGS for consistency with other tracers and Datadog products. NOTE: the legacy DD_TRACE_GLOBAL_TAGS is still supported as a fallback mechanism for backward compatibility but it will removed in a future version.

DD_TAGS preserves the same associative array format, e.g. DD_TAGS=key1:value1,key2:value2

Readiness checklist

  • (only for Members) Changelog has been added to the appropriate release draft. Create one if necessary.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the appropriate release draft. For community contributors the reviewer is in charge of this task.

@labbati labbati added this to the 0.47.0 milestone Jun 12, 2020
@labbati labbati changed the title Add support for DD_TAGS, fallback to DD_TARCE_GLOBAL_TAGS Add support for DD_TAGS, fallback to DD_TRACE_GLOBAL_TAGS Jun 12, 2020
@labbati labbati marked this pull request as ready for review June 12, 2020 09:25
@labbati
Copy link
Copy Markdown
Member Author

labbati commented Jun 12, 2020

Lint is failing because of an index in the OS repo. Will try to restart at a later time.

@labbati labbati mentioned this pull request Jun 12, 2020
Merged
5 tasks
SammyK
SammyK previously approved these changes Jun 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@SammyK SammyK added the 🏆 enhancement A new feature or improvement label Jun 15, 2020
morrisonlevi
morrisonlevi previously approved these changes Jun 15, 2020
View reviewed changes
@labbati labbati dismissed stale reviews from morrisonlevi and SammyK via 74836c2 June 15, 2020 15:28
@labbati
Copy link
Copy Markdown
Member Author

labbati commented Jun 15, 2020 •
edited
Loading

Can you please take a final look after the merge conflict resolution?

@labbati labbati merged commit c3041e4 into master Jun 16, 2020
@labbati labbati deleted the labbati/DD_TAGS branch June 16, 2020 13:30
@morrisonlevi morrisonlevi mentioned this pull request Jul 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrisonlevi morrisonlevi morrisonlevi approved these changes

+1 more reviewer

@SammyK SammyK SammyK left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🏆 enhancement A new feature or improvement

Projects

None yet

Milestone

0.47.0

Development

Successfully merging this pull request may close these issues.

3 participants

@labbati @morrisonlevi @SammyK