Add support for service name configuration via DD_SERVICE#919
Merged
Add support for service name configuration via DD_SERVICE#919
Conversation
… DD_SERVICE_NAME for BC compatibility
…t would work in any case
labbati
added
the
c-extension
SammyK
approved these changes
Jun 15, 2020
morrisonlevi
approved these changes
Jun 15, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecation notice" Setting service name via
DD_SERVICE_NAMEis now deprecated and will be removed in a future release. UseDD_SERVICEinstead for consistency with other Datadog tracers and services.This PR adds support for both
DD_SERVICE(primary) andDD_SERVICE_NAME(secondary) as env variable names to configure the service name.This was done as part of an effort to increase consistency among different tracers and Datadog products.
Readiness checklist
Reviewer checklist