Conversation
morrisonlevi
reviewed
Jun 4, 2020
70136da to
6cb95c9
Compare
6cb95c9 to
1da2232
Compare
6f38016 to
abc2853
Compare
abc2853 to
0066135
Compare
This is needed in oder to support the configurable sampler which allows custom sampling priorities per service or span name.
c28be00 to
d2672f7
Compare
morrisonlevi
approved these changes
Jun 9, 2020
Collaborator
morrisonlevi
left a comment
There was a problem hiding this comment.
Testing if static analysis is required for merge.
morrisonlevi
approved these changes
Jun 9, 2020
Collaborator
morrisonlevi
left a comment
There was a problem hiding this comment.
Looks good, Sammy. Thanks for wading through PHP 5!
5 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up PR to #814. This sandboxes the cURL integration on PHP 5.6 (PHP 5.4 is still limited to the legacy API so it does not apply.)
As in #814, this PR also provides custom internal function handlers for
curl_exec,curl_copy_handle,curl_close,curl_setopt, andcurl_setopt_arrayin order to inject distributed tracing headers. This PR differs slightly from #814 by injecting the distributed tracing headers with a single userland call toDDTrace\Bridge\curl_inject_distributed_headers()right before thecurl_exec()call. This approach can be used for PHP 7 to reduce the dependency on the userland API.Readiness checklist
Reviewer checklist