chore: add kube pod annotation to debug request-replayer#3978
Conversation
Signed-off-by: Alexandre Rulleau <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 119be3842d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| MAX_TEST_PARALLELISM: 4 | ||
| PHP_MAJOR_MINOR: "<?= $major_minor ?>" | ||
| ARCH: "amd64" | ||
| KUBERNETES_POD_ANNOTATIONS_1: "ci.ddbuild.io/enforce-static-cpus=true" |
There was a problem hiding this comment.
On the Kubernetes runners where ci.ddbuild.io/enforce-static-cpus=true is honored, this job now opts into static CPU allocation while only setting KUBERNETES_CPU_REQUEST; GitLab Runner treats CPU request and limit as separate build-container settings, so the generated pod lacks the matching CPU limit needed for a Guaranteed/static-CPU workload. The other existing static-CPU job in this file sets request and limit together, so add KUBERNETES_CPU_LIMIT: 12 here or drop the static-CPU annotation to avoid these test_extension_ci jobs being rejected or not receiving the intended pinned CPUs.
Useful? React with 👍 / 👎.
2 participants
Description
Reviewer checklist