libdatadog update to 6760faae#3944
Conversation
This comment has been minimized.
This comment has been minimized.
bbf5aea to
5c82d3b
Compare
61593df to
6c9ce4c
Compare
6cbfc00 to
799e351
Compare
Benchmarks [ tracer ]Benchmark execution time: 2026-06-12 06:39:49 Comparing candidate commit 76d6ef7 in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics.
|
Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/118037424 Full CI result: ❌ 15 job(s) failed
799e351 to
ad1c70c
Compare
Signed-off-by: Bob Weinand <[email protected]>
ea81580 to
63825e4
Compare
63825e4 to
76d6ef7
Compare
… runs Signed-off-by: Bob Weinand <[email protected]>
76d6ef7 to
3e75ca7
Compare
Summary
Automated update of the libdatadog submodule to the latest HEAD.
382a08732c4f0061c55f890830b5206afc3e929f6760faaeeda1cfcf634410105f93cf7149265592Full CI result: ❌ 17 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/118341579
libdatadog Integration Report
libdatadog SHA: 6760faaeeda1cfcf634410105f93cf7149265592
Analysis date: 2026-06-12
Overall status
Build & test summary
17 jobs were reported as failed. They fall into three groups:
Rust compilation failures (13 jobs) — root cause, now fixed.
compile extension: debug: [8.5, arm64]compile tracing extension asan: [...]for 7.4 / 8.0 / 8.1 / 8.2 / 8.3 / 8.4 / 8.5 on bothaarch64-unknown-linux-gnu(arm64) andx86_64-unknown-linux-gnu(amd64)All failed with the identical error:
This is a direct consequence of new libdatadog commit
74284cac7 refactor(span)!: use VecMap for meta, metrics and meta_struct for v04 spans,which replaced the
HashMap-backed maps onSpanByteswith the newVecMaptype.VecMapdeliberately renames the removal method toremove_slow(it isO(n)viaVec::retain, unlike a hashmap). Fixed by updating the 4 call sites (see below).Downstream jobs blocked by the compile failure (2 jobs).
aggregate tested versionspecl tests: [7.0]These consume the extension artifacts produced by the compile stage. They failed because the
Rust library never built (
script_failure); they are expected to pass once the compile fixabove lands. No code change of their own is required.
Unrelated / flaky (2 jobs). See "Flaky / ignored failures".
Once the
remove_slowchange is in place, the entire compile fan-out and its dependent jobsshould build and run again.
Non-trivial changes made
components-rs/bytes.rs—SpanBytes.metaandSpanBytes.metricsare nowVecMapinstead of
HashMap. TheVecMapremoval method is namedremove_slow(the rename signalsits linear-scan cost). Renamed the 4 call sites accordingly; the semantics are unchanged
(
remove_slowremoves all entries matching the key):ddog_del_span_meta_zstr:ptr.meta.remove(...)→ptr.meta.remove_slow(...)ddog_del_span_meta_str:ptr.meta.remove(...)→ptr.meta.remove_slow(...)ddog_del_span_metrics_zstr:ptr.metrics.remove(...)→ptr.metrics.remove_slow(...)ddog_del_span_metrics_str:ptr.metrics.remove(...)→ptr.metrics.remove_slow(...)The other
VecMapaccessors we use (insert,get,contains_key) keep their names, so nofurther changes were needed. Verified there are no other
VecMap::removecall sites in ourRust sources (the remaining
.remove(calls incomponents-rs/operate onHashMap/HashSet).Identified libdatadog issues
None identified. The
remove→remove_slowrename is an intentional breaking API change(commit
74284cac7, marked!), and the new method is a clean drop-in replacement with thesame delete-all-matching-keys semantics. The other breaking changes in the changelog
(
feat(native-spans)! #2046,refactor(rc-fetcher)! #2103,feat(crashtracking)! #2099) didnot surface any compilation errors against our code.
Flaky / ignored failures
appsec integration tests: [test8.4-release]— 344 tests ran, 1 failed:TelemetryExtendedHeartbeatTests > extended heartbeat re-emits configuration, dependencies and integrations()withphpredis not emitted via app-started/app-integrations-change; saw: []; flushed = []. This is a telemetry integration test asserting on the flushed integrations list,which came back empty — a timing/flush race unrelated to the libdatadog span-map change. Ignored
as flaky.
windows test_c: [7.2]andwindows test_c: [7.3]— both failed withjob_execution_timeout(not ascript_failure/compile error). No compilation trace wasproduced. Treated as infrastructure timeout / flakiness, unrelated to the libdatadog API change.
/cc @bwoebi