Skip to content

build(profiling): Allow zend_strdup for profiler macOS release builds#3923

Merged
realFlowControl merged 1 commit into
masterfrom
codex/allow-zend-strdup
May 27, 2026
Merged

build(profiling): Allow zend_strdup for profiler macOS release builds#3923
realFlowControl merged 1 commit into
masterfrom
codex/allow-zend-strdup

Conversation

@realFlowControl

Copy link
Copy Markdown
Member

Summary

Adds ___zend_strdup to the profiler's explicit macOS release-build undefined-symbol allowlist.

Why

PR #3670 (perf(config): cache sys getenv) added persistent duplication in ZAI config via pestrdup, which can surface as the zend_strdup symbol in the profiler link. The profiler release build on macOS uses an explicit allowlist for PHP/Zend symbols resolved by the PHP process at load time, so the missing ___zend_strdup entry regressed release builds.

We need this allowlist entry to build release versions of the profiler on arm64 macOS.

Validation

  • cargo build --release on arm64 macOS

@github-actions github-actions Bot added the profiling Relates to the Continuous Profiler label May 27, 2026
@realFlowControl
realFlowControl marked this pull request as ready for review May 27, 2026 17:35
@realFlowControl
realFlowControl requested a review from a team as a code owner May 27, 2026 17:35
@realFlowControl realFlowControl changed the title [codex] Allow zend_strdup for profiler macOS release builds build(profiling): Allow zend_strdup for profiler macOS release builds May 27, 2026
@realFlowControl
realFlowControl merged commit 98a15de into master May 27, 2026
73 of 268 checks passed
@realFlowControl
realFlowControl deleted the codex/allow-zend-strdup branch May 27, 2026 17:37
@github-actions github-actions Bot added this to the 1.21.0 milestone May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants