Skip to content

Bump vendored libdatadog#3888

Merged
morrisonlevi merged 2 commits into
masterfrom
levi/libdatadog-bump
May 19, 2026
Merged

Bump vendored libdatadog#3888
morrisonlevi merged 2 commits into
masterfrom
levi/libdatadog-bump

Conversation

@morrisonlevi

@morrisonlevi morrisonlevi commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Description

This bumps the vendored libdatadog from commit 2ce59aa to 73cd2f7. The goal here is to pull in my fixes to libdatadog so that various profiling methods are less likely to panic, mostly from OOMs but not only. The profiling changes should be backwards compatible, I made sure not to "fix" things that required public API changes.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented May 19, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | ASAN test_c: [8.1, amd64]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Failed to enable dynamic instrumentation via dynamic configuration in debugger_enable_dynamic_config.phpt

DataDog/apm-reliability/dd-trace-php | test_web_custom: [8.5, cgi-fcgi]   View in Datadog   GitLab

🔄 Retry job. This looks flaky and may succeed on retry. Failed asserting that 'This is a string' is equal to the actual response '<html> <head><title>502 Bad Gateway</title></head> <body> <center><h1>502 Bad Gateway</h1></center> <hr><center>nginx/1.22.1</center> </body> </html> ' at /go/src/github.com/DataDog/apm-reliability/dd-trace-php/tests/Common/TracerTestTrait.php:343.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.73% (-0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3a1fc91 | Docs | Datadog PR Page | Give us feedback!

@morrisonlevi
morrisonlevi force-pushed the levi/libdatadog-bump branch from 22c6aaf to f38b045 Compare May 19, 2026 17:57
@morrisonlevi
morrisonlevi marked this pull request as ready for review May 19, 2026 18:12
@morrisonlevi
morrisonlevi requested a review from a team as a code owner May 19, 2026 18:12

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f38b0453a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread libdatadog
@morrisonlevi
morrisonlevi requested review from a team as code owners May 19, 2026 18:22
@morrisonlevi morrisonlevi added the profiling Relates to the Continuous Profiler label May 19, 2026
@morrisonlevi
morrisonlevi merged commit 607d17a into master May 19, 2026
1957 of 2122 checks passed
@morrisonlevi
morrisonlevi deleted the levi/libdatadog-bump branch May 19, 2026 18:53
@github-actions github-actions Bot added this to the 1.20.0 milestone May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants