Skip to content

feat: turn on reporting all threads for crashtracking#3866

Merged
bwoebi merged 3 commits into
masterfrom
gyuheon0h/include-collecing-all-threads
May 8, 2026
Merged

feat: turn on reporting all threads for crashtracking#3866
bwoebi merged 3 commits into
masterfrom
gyuheon0h/include-collecing-all-threads

Conversation

@gyuheon0h

@gyuheon0h gyuheon0h commented May 7, 2026

Copy link
Copy Markdown
Contributor

Description

Crashtracking now supports collecting all threads at the moment of a crash, with feat(crashtracking)!: collect all threads

This PR updates the git submodule to 24cbf670001d65ba6c2ee318578f3a690df1ac36 and turns collecting all threads on

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gyuheon0h gyuheon0h changed the title Update libdd submodule headers, and include all threads feat: turn on reporting all threads for crashtracking May 7, 2026
@gyuheon0h
gyuheon0h marked this pull request as ready for review May 7, 2026 18:21
@gyuheon0h
gyuheon0h requested review from a team as code owners May 7, 2026 18:21
@gyuheon0h
gyuheon0h requested review from bwoebi and removed request for a team May 7, 2026 18:21
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented May 7, 2026

Copy link
Copy Markdown

Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 31 Tests failed

tests.appsec.test_automated_login_events.Test_V3_Login_Events_Blocking.test_login_event_blocking_auto_id[apache-mod-8.0] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: assert 500 == 200
 +  where 500 = HttpResponse(status_code:500, headers:{'Date': 'Thu, 07 May 2026 21:28:35 GMT', 'Server': 'Apache/2.4.66 (Debian)', 'X...ed-By': 'PHP/8.0.18', 'Content-Length': '0', 'Connection': 'close', 'Content-Type': 'text/html; charset=UTF-8'}, text:).status_code
 +    where HttpResponse(status_code:500, headers:{'Date': 'Thu, 07 May 2026 21:28:35 GMT', 'Server': 'Apache/2.4.66 (Debian)', 'X...ed-By': 'PHP/8.0.18', 'Content-Length': '0', 'Connection': 'close', 'Content-Type': 'text/html; charset=UTF-8'}, text:) = <tests.appsec.test_automated_login_events.Test_V3_Login_Events_Blocking object at 0x7fa6a7dce990>.r_login

self = <tests.appsec.test_automated_login_events.Test_V3_Login_Events_Blocking object at 0x7fa6a7dce990>

    def test_login_event_blocking_auto_id(self):
>       assert self.r_login.status_code == 200
E       AssertionError: assert 500 == 200
E        +  where 500 = HttpResponse(status_code:500, headers:{'Date': 'Thu, 07 May 2026 21:28:35 GMT', 'Server': 'Apache/2.4.66 (Debian)', 'X...ed-By': 'PHP/8.0.18', 'Content-Length': '0', 'Connection': 'close', 'Content-Type': 'text/html; charset=UTF-8'}, text:).status_code
...
tests.appsec.test_automated_login_events.Test_V3_Login_Events_Blocking.test_login_event_blocking_auto_id[php-fpm-8.5] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: assert 500 == 200
 +  where 500 = HttpResponse(status_code:500, headers:{'Date': 'Thu, 07 May 2026 21:47:00 GMT', 'Server': 'Apache/2.4.67 (Ubuntu)', 'X...red-By': 'PHP/8.5.5', 'Content-Length': '0', 'Connection': 'close', 'Content-Type': 'text/html; charset=UTF-8'}, text:).status_code
 +    where HttpResponse(status_code:500, headers:{'Date': 'Thu, 07 May 2026 21:47:00 GMT', 'Server': 'Apache/2.4.67 (Ubuntu)', 'X...red-By': 'PHP/8.5.5', 'Content-Length': '0', 'Connection': 'close', 'Content-Type': 'text/html; charset=UTF-8'}, text:) = <tests.appsec.test_automated_login_events.Test_V3_Login_Events_Blocking object at 0x7fa24e7a32f0>.r_login

self = <tests.appsec.test_automated_login_events.Test_V3_Login_Events_Blocking object at 0x7fa24e7a32f0>

    def test_login_event_blocking_auto_id(self):
>       assert self.r_login.status_code == 200
E       AssertionError: assert 500 == 200
E        +  where 500 = HttpResponse(status_code:500, headers:{'Date': 'Thu, 07 May 2026 21:47:00 GMT', 'Server': 'Apache/2.4.67 (Ubuntu)', 'X...red-By': 'PHP/8.5.5', 'Content-Length': '0', 'Connection': 'close', 'Content-Type': 'text/html; charset=UTF-8'}, text:).status_code
...
tests.appsec.test_automated_login_events.Test_V3_Login_Events_Blocking.test_login_event_blocking_auto_login[apache-mod-8.0] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: assert 500 == 200
 +  where 500 = HttpResponse(status_code:500, headers:{'Date': 'Thu, 07 May 2026 21:29:03 GMT', 'Server': 'Apache/2.4.66 (Debian)', 'X...ed-By': 'PHP/8.0.18', 'Content-Length': '0', 'Connection': 'close', 'Content-Type': 'text/html; charset=UTF-8'}, text:).status_code
 +    where HttpResponse(status_code:500, headers:{'Date': 'Thu, 07 May 2026 21:29:03 GMT', 'Server': 'Apache/2.4.66 (Debian)', 'X...ed-By': 'PHP/8.0.18', 'Content-Length': '0', 'Connection': 'close', 'Content-Type': 'text/html; charset=UTF-8'}, text:) = <tests.appsec.test_automated_login_events.Test_V3_Login_Events_Blocking object at 0x7fa6a7dcdfd0>.r_login

self = <tests.appsec.test_automated_login_events.Test_V3_Login_Events_Blocking object at 0x7fa6a7dcdfd0>

    def test_login_event_blocking_auto_login(self):
>       assert self.r_login.status_code == 200
E       AssertionError: assert 500 == 200
E        +  where 500 = HttpResponse(status_code:500, headers:{'Date': 'Thu, 07 May 2026 21:29:03 GMT', 'Server': 'Apache/2.4.66 (Debian)', 'X...ed-By': 'PHP/8.0.18', 'Content-Length': '0', 'Connection': 'close', 'Content-Type': 'text/html; charset=UTF-8'}, text:).status_code
...
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.67% (-0.04%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b5be6e8 | Docs | Datadog PR Page | Give us feedback!

@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/include-collecing-all-threads branch from 61ba52a to 7e01f23 Compare May 7, 2026 18:55
@pr-commenter

pr-commenter Bot commented May 7, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-05-07 22:12:23

Comparing candidate commit b5be6e8 in PR branch gyuheon0h/include-collecing-all-threads with baseline commit 9fe0330 in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-7.599µs; -6.041µs] or [-6.863%; -5.455%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-9.746µs; -7.954µs] or [-8.822%; -7.200%]

scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead-opcache

  • 🟩 execution_time [-8.033µs; -4.881µs] or [-4.422%; -2.687%]

@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/include-collecing-all-threads branch from 7e01f23 to b5be6e8 Compare May 7, 2026 20:54
@bwoebi
bwoebi merged commit 29b3638 into master May 8, 2026
2109 of 2123 checks passed
@bwoebi
bwoebi deleted the gyuheon0h/include-collecing-all-threads branch May 8, 2026 16:01
@github-actions github-actions Bot added this to the 1.20.0 milestone May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants