Skip to content

Ensure an unique installation directory to avoid conflicts#3835

Merged
bwoebi merged 1 commit into
masterfrom
bob/unique-install-dir
Apr 27, 2026
Merged

Ensure an unique installation directory to avoid conflicts#3835
bwoebi merged 1 commit into
masterfrom
bob/unique-install-dir

Conversation

@bwoebi

@bwoebi bwoebi commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

We don't want to assume a monopoly on /tmp/dd-install.

@bwoebi
bwoebi requested a review from a team as a code owner April 27, 2026 12:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88a3afc91d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread datadog-setup.php Outdated
Comment thread datadog-setup.php Outdated
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Apr 27, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.68% (+0.04%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1c88d5a | Docs | Datadog PR Page | Give us feedback!

@bwoebi
bwoebi force-pushed the bob/unique-install-dir branch from 88a3afc to cc2d4f7 Compare April 27, 2026 12:52
@bwoebi
bwoebi force-pushed the bob/unique-install-dir branch from cc2d4f7 to 1c88d5a Compare April 27, 2026 12:53
@pr-commenter

pr-commenter Bot commented Apr 27, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-04-27 14:10:49

Comparing candidate commit 1c88d5a in PR branch bob/unique-install-dir with baseline commit 96c5f06 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 192 metrics, 1 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-4.411µs; -2.309µs] or [-3.920%; -2.052%]

@bwoebi
bwoebi merged commit 9d9fdac into master Apr 27, 2026
2102 of 2104 checks passed
@bwoebi
bwoebi deleted the bob/unique-install-dir branch April 27, 2026 14:55
@github-actions github-actions Bot added this to the 1.19.0 milestone Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants