Skip to content

Fixup master compatibility of arg_info#3833

Merged
bwoebi merged 1 commit intomasterfrom
bob/php-8.6
Apr 27, 2026
Merged

Fixup master compatibility of arg_info#3833
bwoebi merged 1 commit intomasterfrom
bob/php-8.6

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented Apr 27, 2026

Arginfo in internal functions is now zend_arg_info instead of zend_internal_arg_info.

@bwoebi bwoebi requested a review from a team as a code owner April 27, 2026 10:09
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35055ca729

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread ext/hook/uhook_otel.c Outdated
Comment thread ext/live_debugger.c Outdated
@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 Bot commented Apr 27, 2026 •
edited by datadog-prod-us1-5 Bot
Loading

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 60.69% (+0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c5308e4 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 27, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-04-27 13:37:30

Comparing candidate commit c5308e4 in PR branch bob/php-8.6 with baseline commit b7eb412 in branch master.

Found 3 performance improvements and 3 performance regressions! Performance is the same for 188 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-1.747µs; -0.653µs] or [-10.335%; -3.866%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-3.019µs; -2.421µs] or [-2.658%; -2.131%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-6.410µs; -4.910µs] or [-5.669%; -4.343%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+9.653µs; +12.493µs] or [+3.989%; +5.163%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+7.767µs; +10.668µs] or [+3.183%; +4.372%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+41.661ns; +112.739ns] or [+2.856%; +7.728%]

@bwoebi bwoebi merged commit 919c36a into master Apr 27, 2026
2100 of 2105 checks passed
@bwoebi bwoebi deleted the bob/php-8.6 branch April 27, 2026 16:17
@github-actions github-actions Bot added this to the 1.19.0 milestone Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@Leiyks Leiyks Leiyks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.19.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bwoebi @Leiyks