Fix Request::get() removal in Symfony 8 and add test coverage #3809
Merged
bwoebi merged 2 commits intoDataDog:masterfrom Apr 22, 2026
Merged
Fix Request::get() removal in Symfony 8 and add test coverage #3809bwoebi merged 2 commits intoDataDog:masterfrom
bwoebi merged 2 commits intoDataDog:masterfrom
Conversation
TomBrouws
changed the title
Collaborator
|
Thank you, that looks pretty good at a glance, but let me run our CI on this first :-) |
|
🎯 Code Coverage (details) 🔗 Commit SHA: f539019 | Docs | Datadog PR Page | Give us feedback! |
Collaborator
|
I'll take this PR and fix the CI accordingly. |
Copy the Latest fixture to a permanent Version_7_3 directory before Latest is bumped to Symfony 8.
dd-trace-php is using `Request::get()` in multiple locations, but that method has been removed in Symfony 8.0: symfony/http-foundation@e7e0520 This commit fixes the issue, and extends the Symfony testsuite to cover Symfony 8.0.
TomBrouws
force-pushed
the
tomb/fix-symfony-8
branch
from
c80bdf1 to
f539019
Compare
Contributor
Author
|
@bwoebi Just seeing your comment now, I've already pushed a new version. Verified locally that |
bwoebi
approved these changes
Apr 22, 2026
Collaborator
bwoebi
left a comment
bwoebi
left a comment
There was a problem hiding this comment.
@TomBrouws So, the pipeline just passes, awesome! Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3808
Reviewer checklist