Further helper rust fixes#3803
Conversation
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: f0bb0c8 | Docs | Datadog PR Page | Give us feedback! |
0623c3c to
7f667c9
Compare
Benchmarks [ tracer ]Benchmark execution time: 2026-04-17 17:47:49 Comparing candidate commit 7f667c9 in PR branch Found 2 performance improvements and 2 performance regressions! Performance is the same for 189 metrics, 1 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching1
scenario:SamplingRuleMatchingBench/benchRegexMatching2
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0fdda502b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2a7c56b to
d4e67d5
Compare
This could result in telemetry metrics not being submitted if a certain telemetry client was not active for more than half an hour (could happen if the activity is very low). It would also cause unnecessary (but o/wise benign) metric registrations.
…s; fix racy telemetry log test updateable_waf: when an ASM_DD config fails to be added to the builder, restore the initial ruleset if it was removed, matching the existing restore logic in remove_config. TelemetryTests: wait for the specific bad_config diagnostic log rather than any 3 RC logs, avoiding a race where leftover exception logs from the previous test satisfy the condition before the diagnostic arrives. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Causes flakiness in the tests, as symbolization can take > 10 s.
…sabled If remote config was disabled, client_init would inform the helper that remote config is disabled. However, subsequent config_syncs would neverthless send a remote config path (config_sync doesn't separately send whether remote config is enabled). The path being non-empty the helper-rust would deem remote config enabled and create a new service. In practice, this did not actually result in remote config being enabled, because sidecar being informed through config that it's disabled, the shared memory path would not be written to. Neverthless, this resulted in the creation of extra Service's and extra initializations of the waf, reflected in a higher number of waf.init metrics.
0f47f84 to
f0bb0c8
Compare
Description
Reviewer checklist