Skip to content

Further helper rust fixes#3803

Merged
cataphract merged 10 commits intomasterfrom
glopes/further-helper-rust-fixes
Apr 27, 2026
Merged

Further helper rust fixes#3803
cataphract merged 10 commits intomasterfrom
glopes/further-helper-rust-fixes

Conversation

@cataphract
Copy link
Copy Markdown
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract requested a review from a team as a code owner April 16, 2026 16:18
@cataphract cataphract marked this pull request as draft April 16, 2026 16:18
@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented Apr 16, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.69% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f0bb0c8 | Docs | Datadog PR Page | Give us feedback!

@cataphract cataphract force-pushed the glopes/further-helper-rust-fixes branch from 0623c3c to 7f667c9 Compare April 17, 2026 16:30
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 17, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-04-17 17:47:49

Comparing candidate commit 7f667c9 in PR branch glopes/further-helper-rust-fixes with baseline commit 217c346 in branch master.

Found 2 performance improvements and 2 performance regressions! Performance is the same for 189 metrics, 1 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-1426.724ns; -373.276ns] or [-8.492%; -2.222%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-3.135µs; -2.225µs] or [-2.974%; -2.110%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+74.015ns; +160.785ns] or [+5.165%; +11.220%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+51.790ns; +154.810ns] or [+3.530%; +10.551%]

@cataphract cataphract marked this pull request as ready for review April 23, 2026 16:18
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0fdda502b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread appsec/helper-rust/src/service.rs
cataphract and others added 10 commits April 24, 2026 19:25
This could result in telemetry metrics not being submitted if a certain
telemetry client was not active for more than half an hour (could happen
if the activity is very low).

It would also cause unnecessary (but o/wise benign) metric
registrations.
…s; fix racy telemetry log test

updateable_waf: when an ASM_DD config fails to be added to the builder,
restore the initial ruleset if it was removed, matching the existing
restore logic in remove_config.

TelemetryTests: wait for the specific bad_config diagnostic log rather
than any 3 RC logs, avoiding a race where leftover exception logs from
the previous test satisfy the condition before the diagnostic arrives.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Causes flakiness in the tests, as symbolization can take > 10 s.
…sabled

If remote config was disabled, client_init would inform the helper that
remote config is disabled. However, subsequent config_syncs would
neverthless send a remote config path (config_sync doesn't separately
send whether remote config is enabled). The path being non-empty the
helper-rust would deem remote config enabled and create a new service.

In practice, this did not actually result in remote config being
enabled, because sidecar being informed through config that it's
disabled, the shared memory path would not be written to. Neverthless,
this resulted in the creation of extra Service's and extra
initializations of the waf, reflected in a higher number of waf.init
metrics.
@cataphract cataphract force-pushed the glopes/further-helper-rust-fixes branch from 0f47f84 to f0bb0c8 Compare April 24, 2026 18:26
@cataphract cataphract merged commit 60451dd into master Apr 27, 2026
2101 of 2105 checks passed
@cataphract cataphract deleted the glopes/further-helper-rust-fixes branch April 27, 2026 10:52
@github-actions github-actions Bot added this to the 1.19.0 milestone Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants