Conversation
… live-debugger timeout
- Add valgrind skip guard to agent_sampling.phpt and agent_sampling-standalone-asm_{01,02,03}.phpt:
these tests use synchronous_flush (100ms timeout) + network I/O which time out under valgrind's
10-50x slowdown. Matches the guard already present in agent_sampling_sidecar.phpt.
- Increase debugger_span_probe_class.phpt collection window from 10s to 30s:
the sidecar's async INSTALLED diagnostic for immediately-resolved class probes can arrive
late under resource-constrained CI pods (1 CPU / 512Mi service limit).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3754 +/- ##
==========================================
- Coverage 68.85% 68.84% -0.02%
==========================================
Files 166 166
Lines 19015 19015
Branches 1792 1792
==========================================
- Hits 13093 13091 -2
- Misses 5111 5114 +3
+ Partials 811 810 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
✨ Fix all issues with BitsAI or with Cursor
|
…ass probe Bar's INSTALLED diagnostic is sent asynchronously via sidecar and may not arrive within the collection window under resource-constrained CI environments. Since await_probe_installation() already confirms the hook is installed before any function is called, EMITTING is sufficient proof that the probe works. Reduce threshold to 4 events (Delayed's full RECEIVED/INSTALLED/EMITTING lifecycle + Bar's EMITTING) and switch to --EXPECTREGEX-- to make Bar's INSTALLED optional.
--EXPECTREGEX-- forward slashes in the URL broke the PCRE delimiter. Switch back to --EXPECTF-- and normalize probe 1's state list in PHP: strip INSTALLED (which the sidecar delivers async and may miss the collection window) so the output is deterministic. The hook being installed is already confirmed by await_probe_installation().
symfony/event-dispatcher v7.4.0 introduced a regression in TraceableEventDispatcher that triggers "Undefined array key WorkerRunningEvent" in dev mode. Symfony's error handler converts this PHP warning to an exception, causing messenger:consume to exit with code 1 and breaking testAsyncWithTracerDisabledOnConsume. Pin to 7.3.* to match the other pinned Symfony 7.3.x components (framework-bundle 7.3.4, console 7.3.4, messenger 7.3.3).
bwoebi
approved these changes
Apr 1, 2026
Collaborator
bwoebi
left a comment
bwoebi
left a comment
There was a problem hiding this comment.
Thanks for taking care of this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
agent_sampling.phpt+ 3 ASM variants)debugger_span_probe_class.phptflakiness inmin install testssymfony/event-dispatcherto7.3.*to fixtest_web_symfony_latestWhy
Valgrind / background-sender: these tests use
synchronous_flush(100ms timeout) + network I/O. Under valgrind's 10–50× slowdown the sender never completes, causing 300s timeouts. The skip guard already exists inagent_sampling_sidecar.phpt— these 4 files were missing it.Live-debugger flakiness: probe 1's
INSTALLEDdiagnostic races the collection window under constrained CI pods. Sinceawait_probe_installation()already confirms the hook is installed,INSTALLEDis redundant. Fix reduces threshold to 4 events and stripsINSTALLEDfrom probe 1's output.Symfony latest:
symfony/event-dispatcher v7.4.0introduced anUndefined array key WorkerRunningEventbug inTraceableEventDispatcher(dev mode). Symfony's error handler converts this to an exception, causingmessenger:consumeto exit with code 1. Pinned to7.3.*to match the other Symfony 7.3.x components already pinned incomposer.json.Testing
10-pipeline stability run:
min install tests10/10 ✅,test_extension_cino new failures ✅.