fix(profiling): crash due to AAS getenv#3746
Merged
morrisonlevi merged 1 commit intomasterfrom Mar 27, 2026
Merged
Conversation
morrisonlevi
added
cat:app-crash
profiling
bwoebi
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the profiler uploads its payload, it looks at various environment variables related to Azure App Services (see
ProfilesExporter::newin libdatadog, which callslibdd_common::azure_app_services::AAS_METADATA). The problem is that this is being done on a background thread, so if the main PHP thread changes the environment, such as a php-fpmenv, then it can crash.The fix in this case is simple: just force the lock during minit before we have any threads.
Reviewer checklist