ci: set system resource limits for PHP lang tests#3736
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: de8e710 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3736 +/- ##
==========================================
- Coverage 68.79% 68.78% -0.02%
==========================================
Files 166 166
Lines 19015 19015
Branches 1792 1792
==========================================
- Hits 13081 13079 -2
- Misses 5121 5124 +3
+ Partials 813 812 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
morrisonlevi
force-pushed
the
levi/fix-resources-php-language-tests
branch
3 times, most recently
from
ce78d5d to
5faf65f
Compare
|
The QoS is still not being guaranteed for some reason. Despite this, our requested resources are more accurate and I've set |
Recently we had a job fail with: ``` Spawning 87 workers... Warning: stream_socket_accept(): Accept failed: Connection timed out in /usr/local/src/php/run-tests.php on line 1448 ERROR: Failed to accept connection from worker. ``` This is happening because the job doesn't have the right QOS for resource requests to be respected, so it gets a burstable QOS. Sadly, the default is a burstable QOS. So we specifically request resources so that we'll be assigned a guaranteed QOS.
Fall back to nproc. This is an admission of defeat. I cannot get the job to use the guaranteed QoS despite specifying (I thought) everything the job and dependent services would need.
morrisonlevi
force-pushed
the
levi/fix-resources-php-language-tests
branch
from
5abc126 to
4654e03
Compare
3 participants
Description
Sets the CPU and memory limits for the gitlab jobs for PHP Language Tests. Recently we had a PHP 8.2 job fail with:
Spawning 87 workers is happening because the job doesn't have the right QOS for resource requests to be respected, so it gets a burstable QOS. Sadly, the default is a burstable QOS. So we specifically request resources (even if they are the defaults, such as the else branch) so that we'll be assigned a guaranteed QOS.
Reviewer checklist