Fix SSI crashing on apache reload; add SSI int tests for appsec#3724
Fix SSI crashing on apache reload; add SSI int tests for appsec#3724cataphract merged 1 commit intomasterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3724 +/- ##
==========================================
- Coverage 68.81% 68.78% -0.03%
==========================================
Files 166 166
Lines 19030 19015 -15
Branches 1797 1792 -5
==========================================
- Hits 13095 13079 -16
- Misses 5121 5124 +3
+ Partials 814 812 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
cataphract
force-pushed
the
glopes/ssi-fixes
branch
2 times, most recently
from
f776374 to
1d252ef
Compare
Benchmarks [ appsec ]Benchmark execution time: 2026-03-25 14:25:16 Comparing candidate commit 2ffb2e0 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
Benchmarks [ tracer ]Benchmark execution time: 2026-03-25 13:25:13 Comparing candidate commit 2ffb2e0 in PR branch Found 2 performance improvements and 3 performance regressions! Performance is the same for 187 metrics, 2 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing
scenario:EmptyFileBench/benchEmptyFileBaseline
scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:TraceSerializationBench/benchSerializeTrace-opcache
|
cataphract
force-pushed
the
glopes/ssi-fixes
branch
6 times, most recently
from
5cbfc9b to
257bc70
Compare
cataphract
force-pushed
the
glopes/ssi-fixes
branch
from
257bc70 to
589ea38
Compare
github-actions
Bot
added
profiling
| for (unsigned int i = 0; i < sizeof(ddloader_injected_ext_config) / sizeof(ddloader_injected_ext_config[0]); ++i) { | ||
| if (ddloader_injected_ext_config[i].so_handle) { | ||
| DL_UNLOAD(ddloader_injected_ext_config[i].so_handle); | ||
| ddloader_injected_ext_config[i].so_handle = NULL; |
There was a problem hiding this comment.
That's odd. Isn't ddtrace_shutdown going to be executed after the loader extension shutdown? zend_extension is destroyed in order of registration according to zend_shutdown_extensions.
There was a problem hiding this comment.
Yeah, unfortunately I think this latest iteration is not crashing just by accident. The mshutdown of ddtrace doesn't crash because ddtrace.so is still loaded even after the dlclose, but of course that's just a variant on the initial bug. I can reproduce the crash on 8.3-debug
4 participants
Description
Reviewer checklist