Skip to content

Fixes the tag name for process tags#3709

Merged
dubloom merged 2 commits intomasterfrom
dubloom/wrong-process-tags-tag
Mar 19, 2026
Merged

Fixes the tag name for process tags#3709
dubloom merged 2 commits intomasterfrom
dubloom/wrong-process-tags-tag

Conversation

@dubloom
Copy link
Copy Markdown
Contributor

@dubloom dubloom commented Mar 18, 2026

Description

The tag that was used for process tags was wrong, it should be _dd.tags.process

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@dubloom dubloom requested a review from a team as a code owner March 18, 2026 18:07
wantsui
wantsui approved these changes Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown

@wantsui wantsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wantsui
wantsui reviewed Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown

@wantsui wantsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, how do these files get updated:

dd-trace-php/tests/ext/process_tags.phpt

Line 42 in 3577a54

if (isset($spans[1]['meta']['_dd.process_tags'])) {
?

Asking because there are some more files with the wrong tag, ie process_tags.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 18, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.73%. Comparing base (3577a54) to head (d20193c).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3709      +/-   ##
==========================================
- Coverage   68.81%   68.73%   -0.08%     
==========================================
  Files         166      166              
  Lines       19030    19030              
  Branches     1797     1797              
==========================================
- Hits        13095    13080      -15     
- Misses       5122     5135      +13     
- Partials      813      815       +2
Flag Coverage Δ
helper-rust-integration 78.82% <ø> (ø)
helper-rust-unit 49.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3577a54...d20193c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-prod-us1-4
Copy link
Copy Markdown

datadog-prod-us1-4 bot commented Mar 18, 2026 •
edited by datadog-datadog-prod-us1 bot
Loading

⚠️ Tests

✨ Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 13 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor) 
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:52
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor) 
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69baedfc00000000755f045b7406454f
tid: 69baedfc00000000
hexProcessTraceId: 755f045b7406454f
hexProcessSpanId: 3ac9afc6935c569b
processTraceId: 8457483416060183887
processSpanId: 4236110191929349787

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor) 
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69baee6700000000b0cd047abfa97090
tid: 69baee6700000000
hexProcessTraceId: b0cd047abfa97090
hexProcessSpanId: 81a3339f27c32c33
processTraceId: 12739843846149075088
processSpanId: 9341366810756459571

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d20193c | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 18, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-03-18 19:32:09

Comparing candidate commit d20193c in PR branch dubloom/wrong-process-tags-tag with baseline commit 3577a54 in branch master.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

  • 🟩 execution_time [-1118.330ns; -281.670ns] or [-9.725%; -2.449%]

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-1.716µs; -0.484µs] or [-13.102%; -3.692%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+3.092µs; +4.488µs] or [+2.951%; +4.285%]

@dubloom dubloom merged commit 9cde556 into master Mar 19, 2026
2074 checks passed
@dubloom dubloom deleted the dubloom/wrong-process-tags-tag branch March 19, 2026 08:39
@github-actions github-actions bot added this to the 1.17.0 milestone Mar 19, 2026
bwoebi added a commit that referenced this pull request Mar 20, 2026
@bwoebi
Merge branch 'master' of github.com:DataDog/dd-trace-php into bob/lib…
a32e4f5 
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  feat(sidecar): add thread mode as fallback connection for restricted environments (#3573)
  Migrate deprecated GitLab runner tags (#3715)
  Adds process tags to remote config payload (#3658)
  perf(config): cache sys getenv (#3670)
  Fixes the tag name for process tags (#3709)
  Fix debugger ephemerals handling (#3685)
  Fix #3651: Prevent crash during shutdown in Frankenphp (#3662)
  Add dynamic instrumentation and exception replay to startup logging (#3667)
  chore: bump bytes crate from 1.9.0 to 1.11.1 to address CVE-2026-25541 (#3669)
  Merge pull request #3701 from DataDog/brian.marks/add-ksr-tag
  ci: fix Windows job flakiness caused by dirty workspace (#3694)
  Fixup CI owner association (#3704)
  Add Rust rewrite of the AppSec helper alongside the C++ implementation
  Remove debug instruction
  Fix script order
  debug
  Fix exploration logic
  chore(ci): add final_status property on junit XML [APMSP-2610]
  Fix DD_TRACE_SYMFONY_HTTP_ROUTE=false
  Optimize Symfony http.route caching with path map approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wantsui wantsui wantsui approved these changes

@bwoebi bwoebi bwoebi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dubloom @codecov-commenter @bwoebi @wantsui