ci: move one-pipeline jobs to package child pipeline#3688
Merged
Conversation
|
✨ Fix all issues with BitsAI or with Cursor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3688 +/- ##
==========================================
- Coverage 62.20% 62.17% -0.03%
==========================================
Files 141 141
Lines 13352 13352
Branches 1746 1746
==========================================
- Hits 8305 8302 -3
- Misses 4256 4259 +3
Partials 791 791 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Instead of including one-pipeline.locked.yml in the parent pipeline (which caused package-oci and other shared-pipeline jobs to leak into the parent), move the two supported-configurations validation jobs to generate-shared.php where the shared-pipeline include belongs. This removes all SKIP_SHARED_PIPELINE workarounds that were added as a band-aid in #3679, #3682, and supersedes #3687. The validate_supported_configurations_v2_local_file and update_central_configurations_version_range_v2 jobs now run in the shared-trigger child pipeline (shared-gen.yml), which includes one-pipeline.locked.yml for the required job templates.
Leiyks
force-pushed
the
leiyks/fix-ci-one-pipeline-clean
branch
from
7594851 to
e9c3bd0
Compare
Leiyks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_supported_configurations_v2_local_fileandupdate_central_configurations_version_range_v2from.gitlab-ci.ymltogenerate-package.php(the package child pipeline)SKIP_SHARED_PIPELINEworkarounds from the parent pipelineContext
Commit
a3409cd78added- local: .gitlab/one-pipeline.locked.ymlto the parent pipeline (.gitlab-ci.yml) to get job templates needed by two supported-configurations validation jobs. This accidentally imported all shared-pipeline jobs (package-oci,promote-oci-*,requirements_json_test, etc.) into the parent pipeline, causing cascading failures.Previous PRs #3679, #3682 and open PR #3687 applied
SKIP_SHARED_PIPELINEband-aids to suppress those jobs. This PR addresses the root cause instead:generate-package.phpalready includesone-pipeline.locked.yml, so the two concrete jobs naturally belong there. The parent pipeline no longer includesone-pipeline.locked.ymlat all, so no suppression is needed.Supersedes #3687.
Test plan
package-triggerchild pipeline runsvalidate_supported_configurations_v2_local_fileandupdate_central_configurations_version_range_v2package-oci,promote-oci-*, andrequirements_json_testno longer appear in the parent pipeline